New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost buttons have incorrect padding #3358

Closed

vpicone opened this issue Jul 11, 2019 · 1 comment · Fixed by #3364

Assignees

Labels

severity: 4 type: bug 🐛

Contributor

vpicone commented Jul 11, 2019

per: #1484 ghost buttons should have the same padding left and right to prevent awkward spacing when next to other ghost buttons.

repro:

http://react.carbondesignsystem.com/?path=/story/buttons--default
Adjust knobs to kind: ghost and size: field
Observe how the field button has a padding right unlike the other ghost sizes

vpicone added the type: bug 🐛 label

vpicone changed the title ~~Ghost buttons have incorrect padding right~~ Ghost buttons have incorrect padding

Contributor Author

vpicone commented Jul 11, 2019

Normal ghost buttons also have an extra pixel of left padding (13px vs other buttons 12px)

vpicone mentioned this issue

fix: ghost button normal and field padding #3364

Merged

abbeyhrt added severity: 4 priority: medium labels

abbeyhrt assigned vpicone

vpicone closed this as completed in #3364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment