-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pictograms #389
feat: add pictograms #389
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://carbon-website-git-fork-vpicone-add-pictograms.carbon-design-system.now.sh |
The regex is causing each title to be sentence case even though a fair number of them contain acronyms or capital letters in the second word. Examples:
|
@connor-leech the page uses the |
@vpicone My bad. I'll take a look a that. |
@vpicone Fixing that yml will be pretty time-consuming and I likely won't have time to do it this week. I'll open an issue, but don't let that block you for now. |
Yeah I think they were written by hand so will likely need to be updated by hand as well. |
@laurenmrice that's looks like it's a bug from us processing the svgs in Carbon. Not sure if we want to block this until it gets fixed. Opened an issue here: carbon-design-system/carbon#4106 resolved here carbon-design-system/carbon#4107 |
@laurenmrice @chrisconnors-ibm both issues have been resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the Contribute tab:
The following links don’t work and should be redirected to:
IBM Design Language visual style - https://www.ibm.com/design/language/elements/pictograms/design
IBM Design Sketch Kit - sketch://add-library/cloud/75VZZ
@laurenmrice fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to the best of my knowledge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the picto ‘Petri cultures’ should be under the category 'Life Science' not 'Life Sciences'? It is currently under Life Sciences but that seems to be a category duplicate, but just plural ? @chrisconnors-ibm to clarify.
@laurenmrice that’s an issue with the metadata upstream in carbon. Can you make an issue there? There’s other issues with the metadata capitalization @connor-leech has opened an issue to address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Library page looks good; no errors, no undefined, search works as expected .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will make a separate issue for that and will approve cuz this looks good!
@laurenmrice you're exactly right. If @connor-leech is making other metadata changes in another issue, that'd be a swell place to correct The risks of managing directly yaml values that are supposed to be generated from |
Closes #388