Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug (pictograms): YML category incorrect for 'Petri cultures' #4113

Closed
laurenmrice opened this issue Sep 26, 2019 · 1 comment
Closed

bug (pictograms): YML category incorrect for 'Petri cultures' #4113

laurenmrice opened this issue Sep 26, 2019 · 1 comment
Labels
severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Sep 26, 2019 •
edited
Loading

Referencing this PR: carbon-design-system/carbon-website#389

  • The pictogram 'Petri cultures' should be under the category 'Life Science'. It is currently under a category called 'Life Sciences' but that seems to be a category duplicate that is just pluralized.

  • In the YML file, there is not a category specified for this pictogram which may be causing the problem.

Current:
Screen Shot 2019-09-26 at 1.56.04 PM.png

Should live:
Screen Shot 2019-09-26 at 1.56.18 PM.png
@jnm2377 jnm2377 added priority: low severity: 4 https://ibm.biz/carbon-severity labels Oct 10, 2019
@joshblack
Copy link
Contributor

Going to close this out as I believe it's been addressed!

https://github.com/carbon-design-system/carbon/blob/master/packages/pictograms/categories.yml#L319

image.png

Let me know if not and I can re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattrosno @joshblack @jnm2377 @laurenmrice