Persistify deleted state and load it on daemon startup. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=========================================
- Coverage 66.14% 66.04% -0.1%
=========================================
Files 146 146
Lines 5706 5716 +10
=========================================
+ Hits 3774 3775 +1
- Misses 1932 1941 +9
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=========================================
- Coverage 66.14% 66.04% -0.1%
=========================================
Files 146 146
Lines 5706 5716 +10
=========================================
+ Hits 3774 3775 +1
- Misses 1932 1941 +9
Continue to review full report at Codecov.
|
bors bot
added a commit
that referenced
this pull request
Jan 7, 2019
553: Persistify deleted state and load it on daemon startup. r=townsend2010 a=ricab Fixes #536. This adds a boolean field to each instance specification indicating whether or not it is deleted. This change is backward compatible: the daemon can still load VM specs that do not contain the new flag. Such VMs are regarded as not deleted. Co-authored-by: Ricardo Abreu <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536. This adds a boolean field to each instance specification indicating whether or not it is deleted.
This change is backward compatible: the daemon can still load VM specs that do not contain the new flag. Such VMs are regarded as not deleted.