-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted (trashed) instances are not persistified #536
Comments
We currently don't have delete as part of internal states, even though we treat it as a state for many purposes, including user interface. Two important implications:
I am therefore adding the corresponding |
The plan changed after a bit of discussion. Since we want to be able to recover instances to different states in the future (see #549), we will eventually need to persistify an additional piece of information. The code already stores the deleted "state" independently, freeing the state attribute to store what state to go back to on |
553: Persistify deleted state and load it on daemon startup. r=townsend2010 a=ricab Fixes #536. This adds a boolean field to each instance specification indicating whether or not it is deleted. This change is backward compatible: the daemon can still load VM specs that do not contain the new flag. Such VMs are regarded as not deleted. Co-authored-by: Ricardo Abreu <[email protected]>
The text was updated successfully, but these errors were encountered: