Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update zeebe version to 8.1.0-alpha5 #489

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

deepthidevaki
Copy link
Contributor

Description

Update zeebe version to 8.1.0-alpha5

@deepthidevaki deepthidevaki requested a review from saig0 September 7, 2022 09:06
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Test Results

  47 files    47 suites   1m 53s ⏱️
112 tests 112 ✔️ 0 💤 0
359 runs  359 ✔️ 0 💤 0

Results for commit 8ffef58.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepthidevaki

The last time this was changed to SNAPSHOT to accommodate the changes from the engine abstraction topic, see:

I think it makes sense that we update the version for a new release, but that shouldn't happen on main. Instead, we should probably cut a release by branching and then change the version on that branch. We can then release a version from that branch.

If that doesn't work with the current CI pipelines, then we can make the change to main as you've proposed here, and later rollback to point to SNAPSHOT again for continued development.

❌ Please adjust the target branch.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I was making a wrong assumption. The release does happen on main.

In that case, this looks good to me.

🙇 Please make sure that this change is reverted after the release, to support continued development.

@korthout korthout merged commit 45e6e54 into main Sep 7, 2022
@korthout korthout deleted the update-8.1.0-alpha5 branch September 7, 2022 14:01
@deepthidevaki deepthidevaki removed the request for review from saig0 September 7, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants