Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recent engine refactorings #471

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

ChrisKujawa
Copy link
Member

Description

Adjust the code base to the recent engine abstraction refactorings

Related issues

closes #

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Test Results

  47 files    47 suites   1m 43s ⏱️
112 tests 112 ✔️ 0 💤 0
359 runs  359 ✔️ 0 💤 0

Results for commit 079c8c5.

♻️ This comment has been updated with latest results.

@ChrisKujawa
Copy link
Member Author

ChrisKujawa commented Aug 8, 2022

Interesting that I don't get these errors when I run mvn clean install

[INFO] Reactor Summary for Zeebe Process Test Root 8.1.0-alpha5-SNAPSHOT:
[INFO] 
[INFO] Zeebe Process Test Root ............................ SUCCESS [  2.624 s]
[INFO] Zeebe Process Test API ............................. SUCCESS [  8.813 s]
[INFO] Zeebe Process Test Filters ......................... SUCCESS [  7.413 s]
[INFO] Zeebe Process Test Assertions ...................... SUCCESS [ 11.021 s]
[INFO] Zeebe Process Test Engine .......................... SUCCESS [ 17.319 s]
[INFO] Zeebe Process Test Engine Protocol ................. SUCCESS [  6.693 s]
[INFO] Zeebe Process Test Engine Agent .................... SUCCESS [ 32.207 s]
[INFO] Zeebe Process Test Extension ....................... SUCCESS [ 13.248 s]
[INFO] Zeebe Process Test Extension Testcontainer ......... SUCCESS [  5.132 s]
[INFO] Zeebe Process Test QA .............................. SUCCESS [  0.057 s]
[INFO] Zeebe Process Test QA Abstracts .................... SUCCESS [  2.746 s]
[INFO] Zeebe Process Test QA Embedded ..................... SUCCESS [ 40.777 s]
[INFO] Zeebe Process Test QA Testcontainers ............... SUCCESS [ 52.676 s]
[INFO] Zeebe Process Test Examples ........................ SUCCESS [ 12.535 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:33 min
[INFO] Finished at: 2022-08-08T16:34:13+02:00
[INFO] ------------------------------------------------------------------------

@ChrisKujawa
Copy link
Member Author

@remcowesterhoud 🔔 the build is now green.

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Zelldon 🙇

@remcowesterhoud remcowesterhoud merged commit a5e8c2a into main Aug 9, 2022
@remcowesterhoud remcowesterhoud deleted the zell-engine-refactorings branch August 9, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants