[stable/8.6] deps: use root pom version for module dependencies #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module versions got messed up by renovate.
megglos
force-pushed
the
meg-stable86-module-dep-fix
branch
from
bbc19c2 to
5ac6e99
Compare
|
actually the CI #1494 shouldn't have passed as e.g. backports to 8.5 failed with a compile error that should have been present on 8.6 too, given that the model dependencies are not jdk8 compatible anymore. I wondered why the 8.6 PR passed and found the module dependency setup to be broken, this fixes the setup to use the actual local modules from the maven reactor and as expected breaks the CI due to the jdk 8 conflict. I would merge this like this still as this is the actual state of the branch and other builds have an inconsistent dependency setup. |
|
merging eagerly to make progress and get a reliable CI, happy to apply suggestion in a follow-up |
megglos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Module versions got messed up by renovate.
See e.g. 805ddac , we need to exclude the repo modules in renovate in a follow-up.