Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.5] deps: align camunda model version to 7.22 with camunda/camunda #1496

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Feb 17, 2025

Description

Originally a backport of #1494 but turned out there was a maven setup issue, causing it to get merged while actually it should have failed CI see #1500 (comment) .

Related issues

closes #1493

@megglos megglos requested review from eppdot and removed request for eppdot February 17, 2025 08:18
Copy link

github-actions bot commented Feb 17, 2025

Test Results

 50 files   50 suites   1m 37s ⏱️
138 tests 138 ✅ 0 💤 0 ❌
438 runs  438 ✅ 0 💤 0 ❌

Results for commit 366e9a8.

♻️ This comment has been updated with latest results.

@megglos megglos force-pushed the backport-1494-to-stable/8.5 branch 3 times, most recently from c686900 to 206b326 Compare February 17, 2025 10:47
@megglos megglos requested review from saig0 and eppdot February 17, 2025 11:08
Some modules need to support jdk 8 still, but 7.20+ model lib releases don't.

deps: use bpmn model 7.19 on relevant jdk8 modules

As newer releases are not compatible with jdk 8.
@megglos megglos force-pushed the backport-1494-to-stable/8.5 branch from 206b326 to 366e9a8 Compare February 17, 2025 11:12
@megglos
Copy link
Contributor Author

megglos commented Feb 17, 2025

tagging @npepinpe for review as well, as you previously added the exclusion of updates for the model here cbdfd5c , however we need to update it for the embedded extension to work properly, see this issue #1493 on runtime issues when using 7.19

@megglos megglos requested a review from npepinpe February 17, 2025 11:18
@megglos megglos changed the title [backport stable/8.5] deps: align camunda model version to 7.22 with camunda/camunda deps: align camunda model version to 7.22 with camunda/camunda Feb 17, 2025
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npepinpe
Copy link
Member

So the assertions module will have a different version? 🤔

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are the only two modules which need to be on JDK 8? Seems brittle. What was the result though of the discussion? Can we drop JDK8 and bump it to JDK 11?

@megglos
Copy link
Contributor Author

megglos commented Feb 18, 2025

I guess these are the only two modules which need to be on JDK 8? Seems brittle. What was the result though of the discussion? Can we drop JDK8 and bump it to JDK 11?

I think we should do that, given that C7 is not supporting JDK8 anymore, why would C8?

@aleksander-dytko are you aware of any discussion/decision on that?

@megglos
Copy link
Contributor Author

megglos commented Feb 18, 2025

So the assertions module will have a different version? 🤔

unfortunately it needs to in order to compile with jdk 8 :/, however for the embedded test extension we'll still use 7.22 avoiding the potential runtime issues within the engine, compared to using 7.19 everywhere before:

[INFO] --- dependency:3.6.1:tree (default-cli) @ zeebe-process-test-extension ---
[INFO] io.camunda:zeebe-process-test-extension:jar:8.5.15-SNAPSHOT
[INFO] +- io.camunda:zeebe-process-test-engine:jar:8.5.15-SNAPSHOT:compile
[INFO] |  \- io.camunda:zeebe-workflow-engine:jar:8.5.15:compile (version managed from 8.5.15)
[INFO] |     +- io.camunda:zeebe-dmn:jar:8.5.15:compile
[INFO] |     |  +- org.camunda.bpm.extension.dmn.scala:dmn-engine:jar:1.9.0:compile
[INFO] |     |  |  \- (org.camunda.bpm.model:camunda-dmn-model:jar:7.22.0:compile - version managed from 7.20.0-alpha5; omitted for duplicate)
[INFO] |     |  \- org.camunda.bpm.model:camunda-dmn-model:jar:7.22.0:compile (version managed from 7.22.0)
[INFO] |     |     \- (org.camunda.bpm.model:camunda-xml-model:jar:7.22.0:compile - version managed from 7.22.0; omitted for duplicate)
[INFO] |     \- (org.camunda.bpm.model:camunda-xml-model:jar:7.22.0:compile - version managed from 7.22.0; omitted for duplicate)
[INFO] \- io.camunda:zeebe-process-test-assertions:jar:8.5.15-SNAPSHOT:compile
[INFO]    +- org.camunda.bpm.model:camunda-xml-model:jar:7.22.0:compile (version managed from 7.19.0)
[INFO]    \- io.camunda:zeebe-bpmn-model:jar:8.5.15:compile (version managed from 8.5.15)
[INFO]       \- (org.camunda.bpm.model:camunda-xml-model:jar:7.22.0:compile - version managed from 7.22.0; omitted for duplicate)

@megglos megglos merged commit 0671dad into stable/8.5 Feb 18, 2025
10 checks passed
@megglos megglos deleted the backport-1494-to-stable/8.5 branch February 18, 2025 20:32
@backport-action
Copy link
Collaborator

Backport failed for stable/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.4
git worktree add -d .worktree/backport-1496-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-1496-to-stable/8.4
git switch --create backport-1496-to-stable/8.4
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224

@backport-action
Copy link
Collaborator

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-1496-to-main origin/main
cd .worktree/backport-1496-to-main
git switch --create backport-1496-to-main
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224

@backport-action
Copy link
Collaborator

Backport failed for stable/8.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.6
git worktree add -d .worktree/backport-1496-to-stable/8.6 origin/stable/8.6
cd .worktree/backport-1496-to-stable/8.6
git switch --create backport-1496-to-stable/8.6
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224

@backport-action
Copy link
Collaborator

Backport failed for stable/8.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.7
git worktree add -d .worktree/backport-1496-to-stable/8.7 origin/stable/8.7
cd .worktree/backport-1496-to-stable/8.7
git switch --create backport-1496-to-stable/8.7
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224

@aleksander-dytko
Copy link

I guess these are the only two modules which need to be on JDK 8? Seems brittle. What was the result though of the discussion? Can we drop JDK8 and bump it to JDK 11?

I think we should do that, given that C7 is not supporting JDK8 anymore, why would C8?

@aleksander-dytko are you aware of any discussion/decision on that?

@megglos @npepinpe we will bump to JDK 11 with 8.8. We need to notify customers with the 8.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants