-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.5] deps: align camunda model version to 7.22 with camunda/camunda #1496
Conversation
(cherry picked from commit cc1edd9)
Test Results 50 files 50 suites 1m 37s ⏱️ Results for commit 366e9a8. ♻️ This comment has been updated with latest results. |
c686900
to
206b326
Compare
Some modules need to support jdk 8 still, but 7.20+ model lib releases don't. deps: use bpmn model 7.19 on relevant jdk8 modules As newer releases are not compatible with jdk 8.
206b326
to
366e9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
So the assertions module will have a different version? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these are the only two modules which need to be on JDK 8? Seems brittle. What was the result though of the discussion? Can we drop JDK8 and bump it to JDK 11?
I think we should do that, given that C7 is not supporting JDK8 anymore, why would C8? @aleksander-dytko are you aware of any discussion/decision on that? |
unfortunately it needs to in order to compile with jdk 8 :/, however for the embedded test extension we'll still use 7.22 avoiding the potential runtime issues within the engine, compared to using 7.19 everywhere before:
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.4
git worktree add -d .worktree/backport-1496-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-1496-to-stable/8.4
git switch --create backport-1496-to-stable/8.4
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin main
git worktree add -d .worktree/backport-1496-to-main origin/main
cd .worktree/backport-1496-to-main
git switch --create backport-1496-to-main
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.6
git worktree add -d .worktree/backport-1496-to-stable/8.6 origin/stable/8.6
cd .worktree/backport-1496-to-stable/8.6
git switch --create backport-1496-to-stable/8.6
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.7
git worktree add -d .worktree/backport-1496-to-stable/8.7 origin/stable/8.7
cd .worktree/backport-1496-to-stable/8.7
git switch --create backport-1496-to-stable/8.7
git cherry-pick -x b6a1ce2069072779800e98e0699a0f979b585613 366e9a8fc94bf7976371decbf7ec4bf581f4e224 |
@megglos @npepinpe we will bump to JDK 11 with 8.8. We need to notify customers with the 8.7 release. |
Description
Originally a backport of #1494 but turned out there was a maven setup issue, causing it to get merged while actually it should have failed CI see #1500 (comment) .
Related issues
closes #1493