Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] experiment: test auto-formatting in CI for internal PRs #1131

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Aug 8, 2022

This is test #1 for #1130 -- internal PRs.

With #1130 configured, if I push up a PR for a branch within this repo, does the GITHUB_TOKEN running the auto-format workflow have write access to the branch?

Findings

We can see in the commit log that the workflow did commit a formatting change (note the 2nd commit):

image

Looking at the output from the workflow, we can see the commit happening successfully:

image

Surprisingly, the next step (build-docs) failed, on verifying the formatting. It looks like it checked out the commit at the beginning of the previous step, before the fix was committed.

I'm pretty sure we'd be able to resolve this by updating the build-docs workflow, but I'm not going to look into it because test #2 for #1130 failed.

@pepopowitz pepopowitz added component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels Aug 8, 2022
@pepopowitz pepopowitz self-assigned this Aug 8, 2022
@pepopowitz
Copy link
Collaborator Author

Closing this PR as it is an experiment, and was only created for posterity.

@pepopowitz pepopowitz closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant