[DO NOT MERGE] experiment: test auto-formatting in CI for internal PRs #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is test #1 for #1130 -- internal PRs.
With #1130 configured, if I push up a PR for a branch within this repo, does the
GITHUB_TOKEN
running theauto-format
workflow have write access to the branch?Findings
We can see in the commit log that the workflow did commit a formatting change (note the 2nd commit):
Looking at the output from the workflow, we can see the commit happening successfully:
Surprisingly, the next step (build-docs) failed, on verifying the formatting. It looks like it checked out the commit at the beginning of the previous step, before the fix was committed.
I'm pretty sure we'd be able to resolve this by updating the
build-docs
workflow, but I'm not going to look into it because test #2 for #1130 failed.