[DO NOT MERGE] experiment: configure auto-formatting for all PRs question mark? #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepopowitz
added
kind/enhancement
|
Closing this PR as it was an experiment, and I opened it as a PR only for posterity. |
|
reopening this temporarily to see if the error I'm getting from the forked PR is due to it being closed? |
… both internal and external
|
Closing this again, my experiment is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to see if the
GITHUB_TOKENassociated with this repo has the permissions it needs in order to write commits to forks.More specifically, I wanted to find out if the options I recommended in #1104 are even feasible.
It configures a job in the
build-docsworkflow namedauto-format. This job runsnpm run formatagainst the branch, then commits any updates. I followed this article as a guide.Findings
No luck.
The
GITHUB_TOKENdoes not have write access when running in forks. (Actually, it has a confusing amount of access when running in forks -- See this PR/comment for more details on what we do/do not have permissions to do against a forked repo.).And we don't have access to the setting in this repo to grant it write access, which suggests it's disabled at the org level.