Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for write-functions in pinot triple manager; rename variables #5873

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Add unit test for write-functions in pinot triple manager; rename variables #5873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c0951f
Add unit test for Write-functions in triple manager; rename variables…
bowenxia Apr 4, 2024
3c78093
reformat
bowenxia Apr 5, 2024
7beed4a
Merge branch 'master' into xbowen_pinot_triple_manager_test01
bowenxia Apr 5, 2024
020d807
Merge branch 'master' into xbowen_pinot_triple_manager_test01
bowenxia Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions common/persistence/pinot_visibility_dual_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func TestPinotDualManagerClose(t *testing.T) {
mockDBVisibilityManager.EXPECT().Close().Return().Times(1)
},
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
mockPinotVisibilityManager.EXPECT().Close().Return().Times(1)
Expand Down Expand Up @@ -118,7 +118,7 @@ func TestPinotDualManagerGetName(t *testing.T) {

},
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
mockPinotVisibilityManager.EXPECT().GetName().Return(testTableName).Times(1)
Expand Down Expand Up @@ -166,7 +166,7 @@ func TestPinotDualRecordWorkflowExecutionStarted(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -226,7 +226,7 @@ func TestPinotDualRecordWorkflowExecutionClosed(t *testing.T) {
},
expectedError: fmt.Errorf("error"),
},
"Case0-2: error case with ES has errors in dual mode": {
"Case0-2: error case with Pinot has errors in dual mode": {
context: context.Background(),
request: request,
mockDBVisibilityManager: NewMockVisibilityManager(ctrl),
Expand All @@ -250,7 +250,7 @@ func TestPinotDualRecordWorkflowExecutionClosed(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
context: context.Background(),
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
Expand Down Expand Up @@ -283,7 +283,7 @@ func TestPinotDualRecordWorkflowExecutionClosed(t *testing.T) {
},
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
},
"Case2-2: choose ES visibility manager when it is nil": {
"Case2-2: choose Pinot visibility manager when it is nil": {
context: context.Background(),
request: request,
mockDBVisibilityManager: NewMockVisibilityManager(ctrl),
Expand All @@ -292,7 +292,7 @@ func TestPinotDualRecordWorkflowExecutionClosed(t *testing.T) {
},
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOn),
},
"Case2-3: choose both when ES is nil": {
"Case2-3: choose both when Pinot is nil": {
context: context.Background(),
request: request,
mockDBVisibilityManager: NewMockVisibilityManager(ctrl),
Expand All @@ -310,7 +310,7 @@ func TestPinotDualRecordWorkflowExecutionClosed(t *testing.T) {
},
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeDual),
},
"Case3-1: chooseVisibilityModeForAdmin when ES is nil": {
"Case3-1: chooseVisibilityModeForAdmin when Pinot is nil": {
context: context.WithValue(context.Background(), VisibilityAdminDeletionKey("visibilityAdminDelete"), true),
request: request,
mockDBVisibilityManager: NewMockVisibilityManager(ctrl),
Expand Down Expand Up @@ -396,7 +396,7 @@ func TestPinotDualRecordWorkflowExecutionUninitialized(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -451,7 +451,7 @@ func TestPinotDualUpsertWorkflowExecution(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -506,7 +506,7 @@ func TestPinotDualDeleteWorkflowExecution(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -561,7 +561,7 @@ func TestPinotDualDeleteUninitializedWorkflowExecution(t *testing.T) {
advancedVisibilityWritingMode: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityWritingModeOff),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -618,7 +618,7 @@ func TestPinotDualListOpenWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -675,7 +675,7 @@ func TestPinotDualListClosedWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand All @@ -693,7 +693,7 @@ func TestPinotDualListClosedWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(false),
expectedError: nil,
},
"Case2-2: success case with ES visibility is not nil and read mod is false": {
"Case2-2: success case with Pinot visibility is not nil and read mod is false": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -752,7 +752,7 @@ func TestPinotDualListOpenWorkflowExecutionsByType(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -811,7 +811,7 @@ func TestPinotDualListClosedWorkflowExecutionsByType(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -870,7 +870,7 @@ func TestPinotDualListOpenWorkflowExecutionsByWorkflowID(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -929,7 +929,7 @@ func TestPinotDualListClosedWorkflowExecutionsByWorkflowID(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -988,7 +988,7 @@ func TestPinotDualListClosedWorkflowExecutionsByStatus(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -1045,7 +1045,7 @@ func TestPinotDualGetClosedWorkflowExecution(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -1102,7 +1102,7 @@ func TestPinotDualListWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -1159,7 +1159,7 @@ func TestPinotDualScanWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down Expand Up @@ -1215,7 +1215,7 @@ func TestPinotDualCountWorkflowExecutions(t *testing.T) {
readModeIsFromES: dynamicconfig.GetBoolPropertyFnFilteredByDomain(true),
expectedError: nil,
},
"Case1-2: success case with ES visibility is not nil": {
"Case1-2: success case with Pinot visibility is not nil": {
request: request,
mockPinotVisibilityManager: NewMockVisibilityManager(ctrl),
mockPinotVisibilityManagerAccordance: func(mockPinotVisibilityManager *MockVisibilityManager) {
Expand Down
Loading
Loading