Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for write-functions in pinot triple manager; rename variables #5873

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Add unit test for write-functions in pinot triple manager; rename variables #5873

merged 4 commits into from
Apr 5, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Apr 4, 2024

What changed?
Add unit test for Write-functions in triple manager; rename variables in pinot dual manager

Why?
Code coverage week

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Merging #5873 (7beed4a) into master (9af0e32) will increase coverage by 0.15%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 7beed4a differs from pull request most recent head 020d807. Consider uploading reports for the commit 020d807 to get more accurate results

Additional details and impacted files

see 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b6c47...020d807. Read the comment docs.

abhishekj720
abhishekj720 requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@abhishekj720 abhishekj720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require formatting.

@bowenxia bowenxia requested a review from abhishekj720 April 5, 2024 00:31
@bowenxia bowenxia enabled auto-merge (squash) April 5, 2024 00:38
@bowenxia bowenxia merged commit 8fc9382 into master Apr 5, 2024
18 of 19 checks passed
@bowenxia bowenxia deleted the xbowen_pinot_triple_manager_test01 branch April 5, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekj720 abhishekj720 abhishekj720 approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowenxia @abhishekj720