Ratelimit integration test #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
force-pushed
the
ratelimitIntegrationTest
branch
from
57a93b3 to
a824cd4
Compare
jakobht
force-pushed
the
ratelimitIntegrationTest
branch
from
a824cd4 to
cb2e457
Compare
Codecov Report
Additional details and impacted filessee 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Mar 19, 2024
Adding a seperate suite enables us to se the ratelimits only for this specific test, and not for all the integration tests. Similar to the async_wf_test
jakobht
force-pushed
the
ratelimitIntegrationTest
branch
2 times, most recently
from
031a1ba to
2a61173
Compare
jakobht
force-pushed
the
ratelimitIntegrationTest
branch
from
2a61173 to
d471c88
Compare
Pull Request Test Coverage Report for Build 018eae59-c67e-4c41-bd99-0c7282f5ebcfDetails
💛 - Coveralls |
dkrotx
reviewed
Apr 5, 2024
dkrotx
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this will fail until this PR is merged: #5772
What changed?
Adds integration test for the workflowID specific ratelimits
Why?
We need to make sure the requests and errors are passed correctly all the way to and from the client.
How did you test it?
N/A
Potential risks
Release notes
Documentation Changes