-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new error type that will not be retried by frontend #5772
Merged
jakobht
merged 15 commits into
cadence-workflow:master
from
jakobht:workflowIDRatelimitErrortype
Mar 20, 2024
Merged
Added new error type that will not be retried by frontend #5772
jakobht
merged 15 commits into
cadence-workflow:master
from
jakobht:workflowIDRatelimitErrortype
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
March 11, 2024 15:24
Codecov Report
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e5aae-1ad5-4430-ae44-32c5042f5f22Details
💛 - Coveralls |
taylanisikdemir
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR needs to be updated after this IDL update is landed: cadence-workflow/cadence-idl#165, so we can point the submodule to the correct commit.
What changed?
The workflowID ratelimiting now returns
ServiceBusyError
with a specialReason
, frontend will not retry the requests to history, but will instead immediately return the error to the caller.Why?
We do not want frontend to retry the requests to history when the ratelimit hit is the per workflow one. We just want it to return to the user.
How did you test it?
Tested via integration test and unit test
Potential risks
Release notes
Documentation Changes