Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new error type that will not be retried by frontend #5772

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Mar 11, 2024

Note this PR needs to be updated after this IDL update is landed: cadence-workflow/cadence-idl#165, so we can point the submodule to the correct commit.

What changed?
The workflowID ratelimiting now returns ServiceBusyError with a special Reason, frontend will not retry the requests to history, but will instead immediately return the error to the caller.

Why?
We do not want frontend to retry the requests to history when the ratelimit hit is the per workflow one. We just want it to return to the user.

How did you test it?
Tested via integration test and unit test

Potential risks

Release notes

Documentation Changes

common/util.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #5772 (c44ecf2) into master (5ff845e) will decrease coverage by 0.01%.
The diff coverage is 63.15%.

Additional details and impacted files
Files Coverage Δ
common/types/mapper/proto/errors.go 100.00% <100.00%> (ø)
common/types/mapper/thrift/shared.go 97.61% <100.00%> (+<0.01%) ⬆️
common/util.go 78.14% <100.00%> (+0.20%) ⬆️
common/resource/resourceImpl.go 2.43% <0.00%> (ø)
service/matching/service.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff845e...c44ecf2. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 018e5aae-1ad5-4430-ae44-32c5042f5f22

Details

  • 29 of 33 (87.88%) changed or added relevant lines in 8 files are covered.
  • 36 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/service.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 87.63%
common/util.go 2 91.78%
service/matching/taskListManager.go 2 79.7%
service/matching/matcher.go 2 90.72%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 12 84.5%
service/history/execution/mutable_state_task_refresher.go 14 64.24%
Totals Coverage Status
Change from base Build 018e57f2-2987-4aba-b319-ef8a4e1d1935: 0.02%
Covered Lines: 95200
Relevant Lines: 146183

💛 - Coveralls

@jakobht jakobht merged commit bb7ea97 into cadence-workflow:master Mar 20, 2024
20 checks passed
@jakobht jakobht deleted the workflowIDRatelimitErrortype branch March 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants