Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loop from open_connection #20

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Remove loop from open_connection #20

merged 1 commit into from
Jul 4, 2022

Conversation

Tommatheussen
Copy link
Contributor

Fix for #19

It's probably possible to also remove the loop reference inside the init function?

@frenck frenck mentioned this pull request Jun 30, 2022
Closed
@balloob
Copy link

balloob commented Jul 1, 2022

Background on this change:
Python 3.10 removes support for the loop parameter in asyncio methods. For background on this issue, see this StackOverflow answer

@c-soft
Copy link
Owner

c-soft commented Jul 1, 2022

Need to re-setup my environment, will do it this weekend.

1 similar comment
@c-soft
Copy link
Owner

c-soft commented Jul 1, 2022

Need to re-setup my environment, will do it this weekend.

@c-soft
Copy link
Owner

c-soft commented Jul 4, 2022

Accepted.

@c-soft c-soft merged commit 4ac9aa6 into c-soft:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tommatheussen @balloob @c-soft @remmob @nobet78