Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satel Integra: got an unexpected keyword argument 'loop' #74251

Closed
Tommatheussen opened this issue Jun 30, 2022 · 14 comments
Closed

Satel Integra: got an unexpected keyword argument 'loop' #74251

Tommatheussen opened this issue Jun 30, 2022 · 14 comments

Comments

@Tommatheussen
Copy link
Contributor

The problem

The Satel Integra integration is not compatible with Python 3.10 (yet). During initialization errors gets thrown about the connection:

2022-06-30 16:46:38 WARNING (MainThread) [satel_integra.satel_integra] Exception during connecting: BaseEventLoop.create_connection() got an unexpected keyword argument 'loop'.

The library already has a tracking issue for it: c-soft/satel_integra#19, creating issue here to make sure it gets tracked for beta fixes.

What version of Home Assistant Core has the issue?

2022.7.0b0

What was the last working version of Home Assistant Core?

2022.6.7

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Satel Integra

Link to integration documentation on our website

https://www.home-assistant.io/integrations/satel_integra/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2022-06-30 16:46:38 WARNING (MainThread) [satel_integra.satel_integra] Exception during connecting: BaseEventLoop.create_connection() got an unexpected keyword argument 'loop'.
2022-06-30 16:46:38 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration satel_integra: Integration failed to initialize.


### Additional information

_No response_
@probot-home-assistant
Copy link

satel_integra documentation
satel_integra source
(message by IssueLinks)

@frenck frenck changed the title 2022.7 beta: Satel Integra Satel Integra: got an unexpected keyword argument 'loop' Jun 30, 2022
@frenck frenck added this to the 2022.7.0 milestone Jun 30, 2022
@frenck
Copy link
Member

frenck commented Jun 30, 2022

This is an upstream issue in the dependency used: c-soft/satel_integra#19

A fix is here: c-soft/satel_integra#20

However, you knew that already, since you are the author of that PR 😉

Edit: Which you also wrote in the issue description 🤦

@adonno
Copy link

adonno commented Jun 30, 2022

yay can't wait for this to come through

@Rijswijker
Copy link

Is there a way to modify the file as a end user to fix the problem?
I don’t know how to open the correct file because i can’t locate the file(s) of the build-in integrations.

@c-soft
Copy link
Contributor

c-soft commented Jul 6, 2022

I've released new version of the lib, with the fix kindly provided by @Tommatheussen . Before the PR will make across, you can test it by simply changing dependencies: to 0.3.7 from 0.3.4

Relevant files:
requirements_all.txt
components/satel_integra/manifest.json

If yoyu do and it works, pls let me know here.

@frenck
Copy link
Member

frenck commented Jul 7, 2022

Fixed by #74543

@frenck frenck closed this as completed Jul 7, 2022
@mariusnauj
Copy link

mariusnauj commented Jul 7, 2022

@frenck so it's fixed with 7.0 version ?

@frenck
Copy link
Member

frenck commented Jul 7, 2022

This particular issue is fixed in 2022.7.0.

@mariusnauj
Copy link

so if I update my HA, Satel integration will work without any modification from my side?

@frenck
Copy link
Member

frenck commented Jul 7, 2022

@mariusnauj This issue has been fixed. It doesn't say ALL possible issues are fixed. So I cannot answer that question. Fixing one issue may reveal a new one 🤷

@mariusnauj
Copy link

@frenck but if you said fixed, so you tested it ?

@frenck
Copy link
Member

frenck commented Jul 7, 2022

This particular issue has been fixed in pull request #74543, check that one out of your are interested in the details.

I do not own any Satel Integra-related so I did not test it personally. I closed it because it was resolved in the PR.

@Tommatheussen
Copy link
Contributor Author

@mariusnauj I have tested the change myself, currently running the Satel integration as a custom component, with updated library (as explained by c-soft).
The fix will be included in 2022.7.1, so you'll need to wait until that version is released if you don't want to override the integration

@mariusnauj
Copy link

@Tommatheussen thanks for the explanation

@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants