winch(trampolines): Save SP, FP and return address #6400
Conversation
This change is a follow-up to bytecodealliance#6358 This change implements the necessary stores of SP, FP and return address for fast stack walking.
saulecabrera
requested review from
jameysharp and
alexcrichton
and removed request for
a team
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think that failure may be a bug with github's merge queue... |
|
Oh that makes sense; I was taking a look to see if it was a failure due my changes, but all jobs were marked as cancelled. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
It's a bit odd but I think that one is legitimate. I think MSVC failed there with 127, which may mean that there's something Windows-specific about the failure. |
|
Yep, I see it; I'll take a look! |
|
I spent some time debugging this issue and it's indeed legitimate. The root cause of the failure in MSVC is the lack of unwind info, which as far as I understand is required in Windows; I can reproduce the exact same failure by disabling the unwind info generation in Cranelift. I'm working on a separate PR to add support for emitting unwind info in Winch. |
|
Ah that sounds familiar! If you want to add |
|
Sounds good, yeah, I'll ignore them to land this PR and put them back once I introduce support for emitting the unwind information. |
Temporarily ignoring Winch's trap test on Windows while support for unwind information is added.
saulecabrera
force-pushed
the
winch-save-sp-fp-ret-addr
branch
from
75d9eae to
8d75bdc
Compare
…6400) This change is a follow-up to bytecodealliance#6358 This change implements the necessary stores of SP, FP and return address for fast stack walking.
This change is a follow-up to #6358
This change implements the necessary stores of SP, FP and return address for fast stack walking.