Skip to content

Commit

Permalink
Ignore backtrace test on Windows
Browse files Browse the repository at this point in the history
Temporarily ignoring Winch's trap test on Windows while
support for unwind information is added.
  • Loading branch information
saulecabrera committed May 22, 2023
1 parent 62f4d99 commit 8d75bdc
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tests/all/winch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ fn wasm_to_native() -> Result<()> {

#[test]
#[cfg_attr(miri, ignore)]
#[cfg_attr(windows, ignore)]
// NB
//
// This and the following test(`native_to_wasm_trap` and `wasm_to_native_trap`),
// are mostly smoke tests to ensure Winch's trampolines are compliant with fast
// stack walking. The ideal state is one in which we should not have to worry
Expand All @@ -133,6 +135,9 @@ fn wasm_to_native() -> Result<()> {
// code generated by Winch and Cranelift is compliant. One way to achieve this
// could be to share the implementation of trampolines between Cranelift and
// Winch.
//
// FIXME The following two tests are also temporarily ignored on Windows, since
// we are not emitting the require unwind information yet.
fn native_to_wasm_trap() -> Result<()> {
let mut c = Config::new();
c.strategy(Strategy::Winch);
Expand All @@ -159,6 +164,7 @@ fn native_to_wasm_trap() -> Result<()> {

#[test]
#[cfg_attr(miri, ignore)]
#[cfg_attr(windows, ignore)]
fn wasm_to_native_trap() -> Result<()> {
let mut c = Config::new();
c.strategy(Strategy::Winch);
Expand Down

0 comments on commit 8d75bdc

Please sign in to comment.