-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/next/fractal #262
Feature/next/fractal #262
Conversation
23a536b
to
3f645bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor adjustments. Please be sure to include a linter rule for whitespace.
// match: /<\/head>/i, | ||
// }, | ||
// }, | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover comment block, delete or restore please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. It's been restored now.
} | ||
buildPatternLibrary.displayName = `${taskNamePrefix}build`; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a lint check for concurrent whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just rebased on the current next
branch, which contains your recent, shared ESLint setup. I've fixed all the stuff that was being flagged - including the double blank lines - and it's oh so pretty now! ^_^
3f645bd
to
45424a7
Compare
831e17f
to
4d0c524
Compare
4d0c524
to
59e9e19
Compare
2dd46ed
to
b08a218
Compare
b08a218
to
df1bf4d
Compare
df1bf4d
to
db417cc
Compare
affects: @buildit/gravity-ui-nunjucks
db417cc
to
e3a3b70
Compare
affects: @buildit/gravity-ui-nunjucks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think this is probably an example of a feature that may have to be manually merged in? #329
FYI: This did get merged. Github somehow got a bit confused though, so I had to "close" this PR afterwards. |
Closes #264
Related to #106
Description
Ditches Pattern Lab and migrates to Fractal as our tool for generating the pattern library website.
While Pattern Lab has served us well over the years, there are additional features that Fractal has which are useful to us:
Notes for reviewers
The vast majority of changes are simple file renames. Where individual patterns in Pattern Lab were like this:
The equivalent files in Fractal are like this:
Additionally, the JSON files need a top-level
context
property, whose value is the context data. This is because these files can contain other kinds of per-pattern configuration info too.The more interesting changes are in the Gulp scripts. All Pattern Lab stuff has been removed and replaced with the equivalent Fractal functionality. Feel free to ping me if you want me to talk you through any of it.