Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-5412] Cocoa mixed-type stacktraces #1138

Merged

Conversation

nickdowell
Copy link
Contributor

Goal

A change in the design of how React Native native promise rejections would be represented, from an event with multiple errors to a single event with stack frames of mixed types.

This depends on bugsnag/bugsnag-cocoa#902

Changeset

  • Updated bugsnag-cocoa
  • Changed nativeStack parsing to append native stack trace to top of stacktrace

Testing

  • Manually verified using React Native example app

@nickdowell nickdowell changed the title Cocoa mixed-type stacktraces [PLAT-5412] Cocoa mixed-type stacktraces Nov 23, 2020
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 23, 2020

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 24bfb8e

@nickdowell nickdowell force-pushed the nickdowell/cocoa-mixed-stacktrace branch from 4396e86 to 62f8f66 Compare November 24, 2020 15:52
@nickdowell nickdowell force-pushed the nickdowell/cocoa-mixed-stacktrace branch from 62f8f66 to 24bfb8e Compare December 3, 2020 11:28
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 91bc1c9

@bengourley bengourley changed the base branch from next to integration/rn-mixed-stacktraces January 21, 2021 12:22
@bengourley bengourley marked this pull request as ready for review January 21, 2021 12:23
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New bugsnag-stacktrace-types header present and exception/stackframe type values all as expected for RN promise rejections.

@bengourley bengourley merged commit f984928 into integration/rn-mixed-stacktraces Jan 21, 2021
@bengourley bengourley deleted the nickdowell/cocoa-mixed-stacktrace branch January 21, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants