[PLAT-5412] Add BugsnagStackframe.type #902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adding
type
toBugsnagStackframe
is a prerequisite for supporting mixed stack traces containing multiple languages.Design
The
type
parameter is intended to benil
in most cases, and only set if the stack trace contains more than one language - e.g. areactnativejs
exception that contains somecocoa
frames.Because the existing
BSGErrorType
is an int-based enum and cannot naturally represent a nil value, a new Objective-C style string enumBugsnagStackframeType
has been created specifically for this property.In a future notifier update when we are making breaking API changes, we should consider switching all our enums that are serialized as strings to NS_TYPED_ENUMs.
Changeset
type
parameterBugsnagStackframe+Private.h
to remove duplicate declarationsNS_ASSUME_NONNULL
for stack frame headerTesting
type
parameter