Resolve ESLint violations in React Native test fixtures #1099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolves several ESLint violations in the React Native test fixtures.
Design
Apologies for the slightly unwieldy PR - it was very easy to produce with the help of an ESLint literate IDE!
Changeset
The most important aspects of the PR are:
npm run test:lint
catches violations when run locally.test
toDockerfile.ci
, ensuring that the files are in scope for Linting in CI.Testing
In addition to passing CI:
npm run test:lint
gives a clean result locally (and detects the deliberate introduction of a violation in the RN test fixtures).Dockerfile.ci
.