Merge pull request #1099 from bugsnag/rn-test-fixture-linting

Resolve ESLint violations in React Native test fixtures

.eslintignore

@@ -1,9 +1,12 @@
 dist
 examples
-features
 **/node_modules/**
-fixtures
 scratch
 coverage
 packages/core/types/test/*.js
 packages/react-native/android/build/reports
+packages/**/features
+packages/**/fixtures
+test/browser
+test/expo
+test/node

dockerfiles/Dockerfile.ci

@@ -13,5 +13,6 @@ ADD min_packages.tar .
 COPY bin ./bin
 RUN npx lerna bootstrap --concurrency 1
 COPY scripts ./scripts
+COPY test ./test
 COPY packages ./packages
 RUN npm run build

test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js

@@ -1,8 +1,8 @@
 import Scenario from './Scenario'
 
 export class ReactNavigationBreadcrumbsDisabledScenario extends Scenario {
-  constructor(configuration, extraData, jsConfig) {
+  constructor (configuration, extraData, jsConfig) {
     super()
     configuration.enabledBreadcrumbTypes = []
   }
-}
+}

test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js

@@ -1,3 +1,4 @@
 import Scenario from './Scenario'
 
-export class ReactNavigationBreadcrumbsEnabledScenario extends Scenario {}
+export class ReactNavigationBreadcrumbsEnabledScenario extends Scenario {
+}

test/react-native/features/fixtures/app/react_native_navigation_js/scenarios/Scenario.js

@@ -1,8 +1,8 @@
 export default class Scenario {
-  constructor(configuration, extraData, jsConfig) {}
-  run() {}
+  run () {
+  }
 
-  timeout(ms) {
-    return new Promise(resolve => setTimeout(resolve, ms));
+  timeout (ms) {
+    return new Promise(resolve => setTimeout(resolve, ms))
   }
 }

test/react-native/features/fixtures/app/react_native_navigation_js/screens/Details.js

@@ -1,28 +1,30 @@
-import * as React from 'react';
-import {View, Text, Button} from 'react-native';
-import {Navigation} from 'react-native-navigation';
+import * as React from 'react'
+import { View, Text, Button } from 'react-native'
+import { Navigation } from 'react-native-navigation'
 import Bugsnag from '@bugsnag/react-native'
 
 const DetailsScreen = (props) => {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}>
       <Text>Details Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
         onPress={() =>
           Navigation.pop(props.componentId)
-        } />
+        }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('DetailsNavigationError'))} />
+        onPress={() => Bugsnag.notify(new Error('DetailsNavigationError'))}/>
       <Button title='Notify unhandled error'
         accessibilityLabel='sendUnhandled'
-        onPress={() => { throw new Error('DetailsNavigationUnhandledError') }} />
+        onPress={() => {
+          throw new Error('DetailsNavigationUnhandledError')
+        }}/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('detailsSetContext')} />
+        onPress={() => Bugsnag.setContext('detailsSetContext')}/>
     </View>
-  );
-};
+  )
+}
 
-export default DetailsScreen;
+export default DetailsScreen

test/react-native/features/fixtures/app/react_native_navigation_js/screens/Home.js

@@ -1,29 +1,29 @@
-import * as React from 'react';
-import {View, Button, Text} from 'react-native';
-import {Navigation} from 'react-native-navigation';
-import Bugsnag from '@bugsnag/react-native';
+import * as React from 'react'
+import { View, Button, Text } from 'react-native'
+import { Navigation } from 'react-native-navigation'
+import Bugsnag from '@bugsnag/react-native'
 
 const HomeScreen = (props) => {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={ { flex: 1, alignItems: 'center', justifyContent: 'center' } }>
       <Text>Home Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
-        onPress={() =>
+        onPress={ () =>
           Navigation.push(props.componentId, {
             component: {
               name: 'Details'
-            },
+            }
           })
-        } />
+        }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('HomeNavigationError'))} />
+        onPress={ () => Bugsnag.notify(new Error('HomeNavigationError')) }/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('homeSetContext')} />
+        onPress={ () => Bugsnag.setContext('homeSetContext') }/>
     </View>
-  );
-};
+  )
+}
 
-export default HomeScreen;
+export default HomeScreen

test/react-native/features/fixtures/app/react_navigation_js/app/App.js

@@ -1,7 +1,7 @@
-import React, {Component} from 'react'
+import React, { Component } from 'react'
 import Bugsnag from '@bugsnag/react-native'
-import BugsnagPluginReactNavigation from '@bugsnag/plugin-react-navigation';
-import {NavigationContainer} from '@react-navigation/native';
+import BugsnagPluginReactNavigation from '@bugsnag/plugin-react-navigation'
+import { NavigationContainer } from '@react-navigation/native'
 import * as Scenarios from './Scenarios'
 import {
   View,
@@ -17,7 +17,7 @@ const defaultJsConfig = () => ({
 })
 
 export default class App extends Component {
-  constructor(props) {
+  constructor (props) {
     super(props)
     this.state = {
       currentScenario: '',
@@ -107,11 +107,11 @@ export default class App extends Component {
           <TextInput style={styles.textInput}
             placeholder='Scenario Name'
             accessibilityLabel='scenario_name'
-            onChangeText={this.setScenario} />
+            onChangeText={this.setScenario}/>
           <TextInput style={styles.textInput}
             placeholder='Scenario Metadata'
             accessibilityLabel='scenario_metadata'
-            onChangeText={this.setScenarioMetaData} />
+            onChangeText={this.setScenarioMetaData}/>
 
           <Button style={styles.clickyButton}
             accessibilityLabel='start_bugsnag'
@@ -127,17 +127,17 @@ export default class App extends Component {
             style={styles.textInput}
             accessibilityLabel='notify_endpoint'
             value={this.state.notifyEndpoint}
-            onChangeText={this.setNotifyEndpoint} />
+            onChangeText={this.setNotifyEndpoint}/>
           <TextInput placeholder='Sessions endpoint'
             style={styles.textInput}
             accessibilityLabel='sessions_endpoint'
             value={this.state.sessionsEndpoint}
-            onChangeText={this.setSessionsEndpoint} />
+            onChangeText={this.setSessionsEndpoint}/>
           <TextInput placeholder='API key'
             style={styles.textInput}
             accessibilityLabel='api_key'
             value={this.state.apiKey}
-            onChangeText={this.setApiKey} />
+            onChangeText={this.setApiKey}/>
           <Button style={styles.clickyButton}
             accessibilityLabel='use_dashboard_endpoints'
             title='Use dashboard endpoints'
@@ -148,12 +148,12 @@ export default class App extends Component {
   }
 
   ready () {
-    const BugsnagNavigationContainer = Bugsnag.getPlugin('reactNavigation').createNavigationContainer(NavigationContainer);
+    const BugsnagNavigationContainer = Bugsnag.getPlugin('reactNavigation').createNavigationContainer(NavigationContainer)
     return (
       <BugsnagNavigationContainer>
         {this.state.scenario.view()}
       </BugsnagNavigationContainer>
-    );
+    )
   }
 
   render () {

test/react-native/features/fixtures/app/react_navigation_js/app/scenarios/ReactNavigationBreadcrumbsDisabledScenario.js

@@ -1,68 +1,70 @@
 import Scenario from './Scenario'
 import Bugsnag from '@bugsnag/react-native'
 import * as React from 'react'
-import {View, Text, Button} from 'react-native'
-import {createStackNavigator} from '@react-navigation/stack';
+import { View, Text, Button } from 'react-native'
+import { createStackNavigator } from '@react-navigation/stack'
 
 export class ReactNavigationBreadcrumbsDisabledScenario extends Scenario {
-  constructor(configuration, extraData, jsConfig) {
+  constructor (configuration, _extraData, _jsConfig) {
     super()
     configuration.enabledBreadcrumbTypes = []
   }
 
   view () {
-    const Stack = createStackNavigator();
+    const Stack = createStackNavigator()
     return (
       <Stack.Navigator>
         <Stack.Screen
           name="Home"
-          component={HomeScreen}
+          component={ HomeScreen }
         />
         <Stack.Screen
           name="Details"
-          component={DetailsScreen}
+          component={ DetailsScreen }
         />
       </Stack.Navigator>
     )
   }
 
-  run() {
+  run () {
   }
 }
 
-function HomeScreen({navigation}) {
+function HomeScreen ({ navigation }) {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={ { flex: 1, alignItems: 'center', justifyContent: 'center' } }>
       <Text>Home Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
-        onPress={() => navigation.navigate('Details')} />
+        onPress={ () => navigation.navigate('Details') }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('HomeNavigationError'))} />
+        onPress={ () => Bugsnag.notify(new Error('HomeNavigationError')) }/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('homeSetContext')} />
+        onPress={ () => Bugsnag.setContext('homeSetContext') }/>
     </View>
-  );
+  )
 }
 
-function DetailsScreen({navigation}) {
+function DetailsScreen ({ navigation }) {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={ { flex: 1, alignItems: 'center', justifyContent: 'center' } }>
       <Text>Details Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
-        onPress={() => navigation.navigate('Home')} />
+        onPress={ () => navigation.navigate('Home') }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('DetailsNavigationError'))} />
+        onPress={ () => Bugsnag.notify(new Error('DetailsNavigationError')) }/>
       <Button title='Notify unhandled error'
         accessibilityLabel='sendUnhandled'
-        onPress={() => { throw new Error('DetailsNavigationUnhandledError') }} />
+        onPress={ () => {
+          throw new Error('DetailsNavigationUnhandledError')
+        } }/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('detailsSetContext')} />
+        onPress={ () => Bugsnag.setContext('detailsSetContext') }/>
     </View>
-  );
-}
+  )
+}

test/react-native/features/fixtures/app/react_navigation_js/app/scenarios/ReactNavigationBreadcrumbsEnabledScenario.js

@@ -1,68 +1,69 @@
 import Scenario from './Scenario'
 import Bugsnag from '@bugsnag/react-native'
 import * as React from 'react'
-import {View, Text, Button} from 'react-native'
-import {createStackNavigator} from '@react-navigation/stack'
+import { View, Text, Button } from 'react-native'
+import { createStackNavigator } from '@react-navigation/stack'
 
 export class ReactNavigationBreadcrumbsEnabledScenario extends Scenario {
-  constructor(configuration, extraData, jsConfig) {
+  constructor (_configuration, _extraData, _jsConfig) {
     super()
   }
 
   view () {
-    const Stack = createStackNavigator();
+    const Stack = createStackNavigator()
     return (
       <Stack.Navigator>
         <Stack.Screen
           name="Home"
-          component={HomeScreen}
+          component={ HomeScreen }
         />
         <Stack.Screen
           name="Details"
-          component={DetailsScreen}
+          component={ DetailsScreen }
         />
       </Stack.Navigator>
     )
   }
 
-  run() {
-    // Bugsnag.notify(new Error('ReactNavigationBreadcrumbsEnabledScenario'))
+  run () {
   }
 }
 
-function HomeScreen({navigation}) {
+function HomeScreen ({ navigation }) {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={ { flex: 1, alignItems: 'center', justifyContent: 'center' } }>
       <Text>Home Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
-        onPress={() => navigation.navigate('Details')} />
+        onPress={ () => navigation.navigate('Details') }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('HomeNavigationError'))} />
+        onPress={ () => Bugsnag.notify(new Error('HomeNavigationError')) }/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('homeSetContext')} />
+        onPress={ () => Bugsnag.setContext('homeSetContext') }/>
     </View>
-  );
+  )
 }
 
-function DetailsScreen({navigation}) {
+function DetailsScreen ({ navigation }) {
   return (
-    <View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
+    <View style={ { flex: 1, alignItems: 'center', justifyContent: 'center' } }>
       <Text>Details Screen</Text>
       <Button title='Navigate'
         accessibilityLabel='navigate'
-        onPress={() => navigation.navigate('Home')} />
+        onPress={ () => navigation.navigate('Home') }/>
       <Button title='Notify handled error'
         accessibilityLabel='sendHandled'
-        onPress={() => Bugsnag.notify(new Error('DetailsNavigationError'))} />
+        onPress={ () => Bugsnag.notify(new Error('DetailsNavigationError')) }/>
       <Button title='Notify unhandled error'
         accessibilityLabel='sendUnhandled'
-        onPress={() => { throw new Error('DetailsNavigationUnhandledError') }} />
+        onPress={ () => {
+          throw new Error('DetailsNavigationUnhandledError')
+        } }/>
       <Button title='Set context'
         accessibilityLabel='setContext'
-        onPress={() => Bugsnag.setContext('detailsSetContext')} />
+        onPress={ () => Bugsnag.setContext('detailsSetContext') }/>
     </View>
-  );
-}
+  )
+}