Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 rebuild project #670

Merged
merged 28 commits into from
Jun 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0f7058a
Frameworks compile, most tests pass
robinmacharg Jun 2, 2020
9dbb8f7
All projects building, majority of tests passing.
robinmacharg Jun 2, 2020
151f5aa
Rearranged and included some doc files in the xcode project
robinmacharg Jun 2, 2020
12ff840
Remove autocreated target files
robinmacharg Jun 3, 2020
426d805
Moved source files up one level
robinmacharg Jun 3, 2020
449821f
Added test info.plist to project
robinmacharg Jun 3, 2020
eabce9d
Relocated main Info.plist and modulemap
robinmacharg Jun 3, 2020
1443ede
Updated built framework name
robinmacharg Jun 3, 2020
58775bc
Removed old XCode project
robinmacharg Jun 3, 2020
cb8cae6
Add tvOS scheme
robinmacharg Jun 3, 2020
bd654d8
Re-add old xcodeproject with unshared schemes
robinmacharg Jun 3, 2020
b2f009b
Updated podspec for new locations
robinmacharg Jun 3, 2020
9183276
Reenable HandledState Test, enabled coverage, added null test to File…
robinmacharg Jun 3, 2020
08e0d57
Readded Swift tests (removed one redundant duplicate), removed deprec…
robinmacharg Jun 3, 2020
86648a3
Update Makefile, add Travis config to project
robinmacharg Jun 3, 2020
a34ba6e
Added swift to tests
robinmacharg Jun 3, 2020
9463a56
Remove new sources
robinmacharg Jun 3, 2020
b5da708
Moved original sources to new location
robinmacharg Jun 3, 2020
31e9db7
Moved original sources to new location
robinmacharg Jun 3, 2020
880a068
Remove Swift tests from tvOS
robinmacharg Jun 3, 2020
63bad41
Modified static target project path for CI
robinmacharg Jun 3, 2020
613f685
Set static deployment OS version, remove outdated Project directory a…
robinmacharg Jun 3, 2020
0bb3111
Removed Carthage files (no longer required)
robinmacharg Jun 3, 2020
d5ca5ce
Updated all-projects linker flags
robinmacharg Jun 3, 2020
8e53ba9
Disable static catalyst support, temp disable of other CI stages
robinmacharg Jun 3, 2020
5aec9cf
address review feedback
fractalwrench Jun 4, 2020
7097f84
address further review feedback
fractalwrench Jun 4, 2020
6dcd51d
refactor: delete unused Config.xcconfig
fractalwrench Jun 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions Bugsnag.podspec.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Bugsnag",
"version": "5.23.2",
"summary": "Cocoa notifier for SDK for bugsnag.com",
"summary": "The Bugsnag crash reporting framework for Apple platforms.",
"homepage": "https://bugsnag.com",
"license": "MIT",
"authors": {
Expand All @@ -25,29 +25,29 @@
"tvos": "9.2"
},
"source_files": [
"Source/{**/,}*.{m,h,mm,c}"
"Bugsnag/{**/,}*.{m,h,mm,c}"
],
"requires_arc": true,
"public_header_files": [
"Source/BSG_KSCrashReportWriter.h",
"Source/Bugsnag.h",
"Source/BugsnagApp.h",
"Source/BugsnagAppWithState.h",
"Source/BugsnagBreadcrumb.h",
"Source/BugsnagClient.h",
"Source/BugsnagConfiguration.h",
"Source/BugsnagDevice.h",
"Source/BugsnagDeviceWithState.h",
"Source/BugsnagEndpointConfiguration.h",
"Source/BugsnagError.h",
"Source/BugsnagErrorTypes.h",
"Source/BugsnagEvent.h",
"Source/BugsnagMetadata.h",
"Source/BugsnagMetadataStore.h",
"Source/BugsnagPlugin.h",
"Source/BugsnagSession.h",
"Source/BugsnagStackframe.h",
"Source/BugsnagThread.h",
"Source/BugsnagUser.h"
"Bugsnag/Bugsnag.h",
"Bugsnag/Client/BugsnagClient.h",
"Bugsnag/Configuration/BugsnagConfiguration.h",
"Bugsnag/Configuration/BugsnagEndpointConfiguration.h",
"Bugsnag/Configuration/BugsnagErrorTypes.h",
"Bugsnag/Metadata/BugsnagMetadata.h",
"Bugsnag/Metadata/BugsnagMetadataStore.h",
"Bugsnag/Payload/BugsnagApp.h",
"Bugsnag/Payload/BugsnagAppWithState.h",
"Bugsnag/Payload/BugsnagBreadcrumb.h",
"Bugsnag/Payload/BugsnagDevice.h",
"Bugsnag/Payload/BugsnagDeviceWithState.h",
"Bugsnag/Payload/BugsnagError.h",
"Bugsnag/Payload/BugsnagEvent.h",
"Bugsnag/Payload/BugsnagSession.h",
"Bugsnag/Payload/BugsnagStackframe.h",
"Bugsnag/Payload/BugsnagThread.h",
"Bugsnag/Payload/BugsnagUser.h",
"Bugsnag/Plugins/BugsnagPlugin.h",
"Bugsnag/BSG_KSCrashReportWriter.h"
]
}
3,384 changes: 3,384 additions & 0 deletions Bugsnag.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "E7397DC31F83BAC50034242A"
BuildableName = "libBugsnagStatic.a"
BlueprintName = "BugsnagStatic"
BlueprintIdentifier = "00AD1C7124869B0E00A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-iOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
</BuildableReference>
</BuildActionEntry>
Expand All @@ -26,8 +26,19 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "00AD1C7A24869B0E00A27979"
BuildableName = "Bugsnag-iOSTests.xctest"
BlueprintName = "Bugsnag-iOSTests"
ReferencedContainer = "container:Bugsnag.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
Expand All @@ -50,9 +61,9 @@
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "E7397DC31F83BAC50034242A"
BuildableName = "libBugsnagStatic.a"
BlueprintName = "BugsnagStatic"
BlueprintIdentifier = "00AD1C7124869B0E00A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-iOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD612478369100731BF5"
BlueprintIdentifier = "00AD1CAC24869C1200A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-macOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
Expand All @@ -26,15 +26,16 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD692478369200731BF5"
BuildableName = "Bugsnag-MacOSTests.xctest"
BlueprintName = "Bugsnag-MacOSTests"
BlueprintIdentifier = "00AD1CB424869C1200A27979"
BuildableName = "Bugsnag-macOSTests.xctest"
BlueprintName = "Bugsnag-macOSTests"
ReferencedContainer = "container:Bugsnag.xcodeproj">
</BuildableReference>
</TestableReference>
Expand All @@ -60,7 +61,7 @@
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD612478369100731BF5"
BlueprintIdentifier = "00AD1CAC24869C1200A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-macOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD7D2478370000731BF5"
BlueprintIdentifier = "00AD1CC824869C2400A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-tvOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
Expand All @@ -26,13 +26,14 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD852478370100731BF5"
BlueprintIdentifier = "00AD1CD024869C2400A27979"
BuildableName = "Bugsnag-tvOSTests.xctest"
BlueprintName = "Bugsnag-tvOSTests"
ReferencedContainer = "container:Bugsnag.xcodeproj">
Expand Down Expand Up @@ -60,7 +61,7 @@
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "009BBD7D2478370000731BF5"
BlueprintIdentifier = "00AD1CC824869C2400A27979"
BuildableName = "Bugsnag.framework"
BlueprintName = "Bugsnag-tvOS"
ReferencedContainer = "container:Bugsnag.xcodeproj">
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Empty file removed Cartfile
Empty file.
Empty file removed Cartfile.resolved
Empty file.
80 changes: 0 additions & 80 deletions Configurations/Config.xcconfig

This file was deleted.

4 changes: 1 addition & 3 deletions Project/TestsInfo.plist → Framework/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
<string>BNDL</string>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Expand Down
6 changes: 6 additions & 0 deletions Framework/module.modulemap
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
framework module Bugsnag {
umbrella header "Bugsnag.h"

export *
module * { export * }
}
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
PLATFORM?=iOS
OS?=latest
TEST_CONFIGURATION?=Debug
BUILD_FLAGS=-project Project/Bugsnag.xcodeproj -scheme Bugsnag-$(PLATFORM) -derivedDataPath build/build-$(PLATFORM)
BUILD_FLAGS=-project Bugsnag.xcodeproj -scheme Bugsnag-$(PLATFORM) -derivedDataPath build/build-$(PLATFORM)

ifeq ($(PLATFORM),macOS)
SDK?=macosx
Expand Down Expand Up @@ -71,7 +71,7 @@ bootstrap: ## Install development dependencies
@bundle install

build_ios_static: ## Build the static library target
$(XCODEBUILD) -project Project/Bugsnag.xcodeproj -scheme BugsnagStatic
$(XCODEBUILD) -project Bugsnag.xcodeproj -scheme BugsnagStatic

build_carthage: ## Build the latest pushed commit with Carthage
@mkdir -p features/fixtures/carthage-proj
Expand Down
Loading