-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 rebuild project #670
V6 rebuild project #670
Conversation
55ec8c9
to
52f0705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few things that differ compared to the previous project that I believe need to change:
- The Link Binary with Libraries step appears to be missing the frameworks from the previous project
- The BugsnagStatic target is missing a copy headers build phase, which means headers will not be available for React Native
- The BugsnagStatic target is missing around half the required .m files from the Compile Sources Build phase
- The test targets have an inconsistent number of files in their build phase
I've tested this by confirming that it works in the Obj-C example project - we would need to test against all our installation instructions before merging this.
Updated PR to address the review points raised above - I've tested out on an example app using Cocoapods only. @tomlongridge would be good to get another pair of eyes reviewing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need Configurations/Config.xcconfig
any more? I believe this was used to share config across projects (but was causing the manual install instructions to break), so I believe it is now unused.
…BasedTest, tweaked framework build names
bc75841
to
7097f84
Compare
|
e5228f7
to
6dcd51d
Compare
Goal
Previous work to combine three separate Xcode projects didn't go far enough and left a folder structure that didn't follow Apple best-practice and, further, wasn't amenable to consistent install instructions. This work rebuilds the entire project structure to address these issues.
Design
Commits were granular and show the progression towards a stable state. Pushes were frequent to ensure that CI issues were addressed. Builds were attempted frequently locally. Popular open source frameworks were consulted to ensure best (common) practice was followed as much as possible.
Changeset
Tests
Manual install, Cocoapods, Carthage both local and remote.