Add nullability annotations to Configuration #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
reviewed
Dec 13, 2018
| @@ -336,7 +344,7 @@ public void setNotifyReleaseStages(@Nullable String[] notifyReleaseStages) { | |||
| * | |||
| * @param projectPackages a list of package names | |||
| */ | |||
| public void setProjectPackages(String[] projectPackages) { | |||
| public void setProjectPackages(@NonNull String[] projectPackages) { | |||
There was a problem hiding this comment.
the getter for this is @Nullable but the setter is @NonNull. As is get|setNotifyReleaseStages(…). Is this intentional? Can they be set to null elsewhere internally, but not via the setter?
bengourley
approved these changes
Dec 13, 2018
|
Comments/remaining work will be addressed in #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #395 for an in-depth explanation.