-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address existing UnknownNullness lint violations #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nullability annotations to public Client methods
Add nullability annotations to public Bugsnag methods
Merging in feature branches to address any remaining comments in one place, and check that:
|
Add nullability annotations to public NativeInterface methods
Add nullability annotations to Configuration
Add nullability annotations to remaining public methods
I've now double-checked that each getter/setter is consistent with the annotation used, which should address all remaining feedback. |
bengourley
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The newly added
UnknownNullness
lint check has identified several sites in bugsnag-android's public API where the nullability is not explicitly defined. We should annotate these as eitherNonNull
, orNullable
, so that Kotlin users can gain the benefit of compile-time safety.For example, adding the
NonNull
annotation to the Client constructor would have the following effect:Further reading: https://developer.android.com/kotlin/interop#java_for_kotlin_consumption
Changeset
Due to the number of violations, this PR will serve as an integration branch for other PRs that address the lint violations. This PR also has regenerated the lint_baseline used to suppress warnings, as its line numbers/warnings are out of date due to changes in #389.
WIP
After all the PRs have been integrated into this branch, the lint_baseline check will be run once more to ensure that no UnknownNullness violations were missed.
Additionally, code inspection will be run to ensure there aren't any inconsistencies in the nullability annotations (for example, a NonNull method which can return null). This should also identify some potential bugs around null checks which can be moved out into separate tickets.