This repository has been archived by the owner on May 13, 2024. It is now read-only.
Publisher status refresh now shows confirmation #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
from
3a17b7e to
59e4deb
Compare
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
from
59e4deb to
9ffa074
Compare
28 tasks
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
5 times, most recently
from
e05d536 to
46903e8
Compare
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
from
46903e8 to
72d9997
Compare
ryanml
reviewed
May 27, 2019
| @@ -312,6 +312,11 @@ storiesOf('Feature Components/Rewards/Concepts/Desktop', module) | |||
|
|
|||
| const onRefreshPublisher = () => { | |||
| store.set({ refreshingPublisher: !store.state.refreshingPublisher }) | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
nit: can we just pass a single object with three props to store.set?
ryanml
reviewed
May 27, 2019
| to { | ||
| opacity: 0; | ||
| } | ||
| ` |
NejcZdovc
previously requested changes
May 27, 2019
| @@ -97,6 +105,7 @@ export default class Profile extends React.PureComponent<Props, {}> { | |||
| ) : null} | |||
| </StyledTitleWrap> | |||
| {verified && type === 'big' ? ( | |||
| !refreshingPublisher && !publisherRefreshed ? | |||
There was a problem hiding this comment.
Could we split all code bellow (that is inside StyledContent) into separate function? This way function will tell us more what is going on, because current code is quire hard to read with nested if statements
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
2 times, most recently
from
cc1a24e to
cf7ee70
Compare
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
2 times, most recently
from
2c93266 to
470992d
Compare
jasonrsadler
force-pushed
the
pub-refresh-illus
branch
from
470992d to
04f97d2
Compare
NejcZdovc
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Partial for brave/brave-browser#4351
Publisher panel refresh now has a confirmation signal to let the user know that the check is complete.
Test plan
in brave-core
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?