Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No visual confirmation that a verified publisher check is done in rewards panel #4351

Closed
srirambv opened this issue May 8, 2019 · 4 comments · Fixed by brave/brave-core#2491

Comments

@srirambv
Copy link
Contributor

srirambv commented May 8, 2019

Description

No visual confirmation that a verified publisher check is done in rewards panel

Steps to Reproduce

  1. Install 0.64.x
  2. Visit any site and open rewards panel
  3. Click on Check Again next to the publisher name
  4. There is no visual confirmation that a check is completed once the spinner is completed the check

Actual result:

No visual confirmation that a check is completed once the spinner is completed the check

Expected result:

Should show a Completed or Check complete message once the spinner is completed the check

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    N/A
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

cc: @NejcZdovc please change priority if needed

@srirambv srirambv added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels May 8, 2019
@jasonrsadler
Copy link

@mandar-brave What text should we display?

@mandar-brave
Copy link

If success, the rewards verified icon should show up.
if failure, the check again button should continue to stay.

I don't believe there is a "failure" message necessary.

@jenn-rhim @alexwykoff

@alexwykoff
Copy link

After conferring with design & dev, this is the agreed solution:
Screen Shot 2019-05-16 at 4 32 12 PM

jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 29, 2019
@jasonrsadler jasonrsadler added this to the 0.67.x - Nightly milestone May 29, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

gif of when site is not verified after checking:
4351-unverified

Verification passed on

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux
  • Verified the STR from the description, now there is spinner visual indication after clicking on Refresh Status
    Refresh status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants