Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ad rewards not updated at brave://rewards due to loss of precision - 1.24.x #8851

Closed
wants to merge 1 commit into from
Closed

Fixes ad rewards not updated at brave://rewards due to loss of precision - 1.24.x #8851

wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 18, 2021

Uplift of #8786
Resolves brave/brave-browser#15801

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team May 18, 2021 18:56
@tmancey tmancey self-assigned this May 18, 2021
@tmancey tmancey added this to the 1.24.x - Release #4 milestone May 18, 2021
@tmancey tmancey force-pushed the issues/15801-1.24.x branch from 33efd0b to 8d7aa09 Compare May 19, 2021 21:01
@kjozwiak
Copy link
Member

Closing this PR as @brave/uplift-approvers decided this will go into 1.25.x next week. Because 1.24.x - Release #4 had #8843 which was a release/blocker, we couldn't wait to get this into it.

@kjozwiak kjozwiak closed this May 20, 2021
@kjozwiak kjozwiak removed the request for review from a team May 20, 2021 02:06
@kjozwiak kjozwiak removed this from the 1.24.x - Release #4 milestone May 20, 2021
@tmancey tmancey deleted the issues/15801-1.24.x branch June 11, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak