Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't override website's document.adoptedStyleSheets (uplift to 1.21.x) #8090

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 27, 2021

Uplift of #8081
Resolves brave/brave-browser#14333

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 27, 2021 00:22
@brave-builds brave-builds requested a review from a team February 27, 2021 00:22
@brave-builds brave-builds self-assigned this Feb 27, 2021
@brave-builds brave-builds added this to the 1.21.x - Release milestone Feb 27, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2021

audit-deps failed on post-init due to a known issue as per https://ci.brave.com/job/pr-brave-browser-pr8081_adoptedstylesheets_1.21.x-post-init/1/execution/node/144/log/.

test-browser failed on macOS due to BraveNavigatorUserAgentFarblingBrowserTest.FarbleNavigatorUserAgent failing as per https://ci.brave.com/job/pr-brave-browser-pr8081_adoptedstylesheets_1.21.x-macos/1/execution/node/241/log/ & https://ci.brave.com/job/pr-brave-browser-pr8081_adoptedstylesheets_1.21.x-macos/1/execution/node/244/log/ which is a known intermittent issue as per brave/brave-browser#13948.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8081 (comment) & #8081 (comment).

@kjozwiak kjozwiak merged commit e5fef6c into 1.21.x Mar 1, 2021
@kjozwiak kjozwiak deleted the pr8081_adoptedstylesheets_1.21.x branch March 1, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants