Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't override website's document.adoptedStyleSheets #8081

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#14333

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@@ -88,7 +88,8 @@ const char kHideSelectorsInjectScript[] =
if (!document.adoptedStyleSheets.includes(
window.content_cosmetic.cosmeticStyleSheet)) {
document.adoptedStyleSheets =
[window.content_cosmetic.cosmeticStyleSheet];
[window.content_cosmetic.cosmeticStyleSheet,
...document.adoptedStyleSheets];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this can overwrite a website's stylesheet, is it possible for websites to "clear" cosmetic filtering that we set this way too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps a way to prevent that is to check and reapply when we do passes for 1st party to unhide

@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner February 26, 2021 01:46
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2021

Verification PASSED on Win 10 x64 using the following build:

1.20.110 CR: 88.0.4324.192 1.23.10 CR: 89.0.4389.69
image image

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2021

Verification passed on OnePlus 6T with Android 10 running 1.23.9 x64 nightly build

  • Verified text colour was blue as expected
  • Verified changing cosmetic filter flag didn't affect it
    image

SergeyZhukovsky pushed a commit that referenced this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave overwrites document.adoptedStyleSheets
6 participants