Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extensions-common-manifest_url_handlers.cc.patch #8065

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

mariospr
Copy link
Contributor

This can be removed in favour of a chromium_src override to redefine
ManifestURL::GetWebStoreURL() into a method that unconditionally
returns an empty GURL.

Note that we need to also redefine GetHomepageURL() as it contains
a call to GetWebStoreURL(), otherwise upstream's version of the
GetWebStoreURL() function would be still be invoked via that way.
This is not ideal, but at least the code in GetHomepageURL() that
needs to be replicated in the chromium_src is very small and very
stable (hasn't changed in 8 years), so risk should be minimal.

Resolves brave/brave-browser#14343

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Based on the test plan from #215:
Go to chrome://extensions and see details of PDF Viewer extension, won't see the row for calling out to chrome web store.

This can be removed in favour of a chromium_src override to redefine
ManifestURL::GetWebStoreURL() into a method that unconditionally
returns an empty GURL.

Note that we need to also redefine GetHomepageURL() as it contains
a call to GetWebStoreURL(), otherwise upstream's version of the
GetWebStoreURL() function would be still be invoked via that way.
This is not ideal, but at least the code in GetHomepageURL() that
needs to be replicated in the chromium_src is very small and very
stable (hasn't changed in 8 years), so risk should be minimal.

Resolves brave/brave-browser#14343
@mariospr mariospr added this to the 1.23.x - Nightly milestone Feb 24, 2021
@mariospr mariospr requested a review from a team as a code owner February 24, 2021 16:09
@mariospr mariospr self-assigned this Feb 24, 2021
@mariospr mariospr requested a review from mkarolin February 24, 2021 19:40
@mariospr
Copy link
Contributor Author

@mkarolin Bots finished now, so another one up for review, thanks!

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extensions-common-manifest_url_handlers.cc.patch
2 participants