Remove extensions-common-manifest_url_handlers.cc.patch #8065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be removed in favour of a chromium_src override to redefine
ManifestURL::GetWebStoreURL() into a method that unconditionally
returns an empty GURL.
Note that we need to also redefine GetHomepageURL() as it contains
a call to GetWebStoreURL(), otherwise upstream's version of the
GetWebStoreURL() function would be still be invoked via that way.
This is not ideal, but at least the code in GetHomepageURL() that
needs to be replicated in the chromium_src is very small and very
stable (hasn't changed in 8 years), so risk should be minimal.
Resolves brave/brave-browser#14343
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Based on the test plan from #215:
Go to chrome://extensions and see details of PDF Viewer extension, won't see the row for calling out to chrome web store.