You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This patch could be removed in favour of a chromium_src override to redefine ManifestURL::GetWebStoreURL() into a method that unconditionally returns an empty GURL
This can be removed in favour of a chromium_src override to redefine
ManifestURL::GetWebStoreURL() into a method that unconditionally
returns an empty GURL.
Note that we need to also redefine GetHomepageURL() as it contains
a call to GetWebStoreURL(), otherwise upstream's version of the
GetWebStoreURL() function would be still be invoked via that way.
This is not ideal, but at least the code in GetHomepageURL() that
needs to be replicated in the chromium_src is very small and very
stable (hasn't changed in 8 years), so risk should be minimal.
Resolvesbrave/brave-browser#14343
Brave | 1.23.52 Chromium: 89.0.4389.105 (Official Build) dev (64-bit)
-- | --
Revision | 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS | Windows 10 OS Version 2004 (Build 19041.867)
Verified that the PDF Viewer extension is bundled and not attributed to the Chrome Web Store, when launching with:
Verified passed with
Brave 1.23.63 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Linux
Verified the test plan from brave/brave-core#8065 (comment) when launching with --args --enable-logging=stderr --show-component-extension-options:
Removing OS/Android label as PDF is handled natively in Android and chrome://extensions doesn't resolve as extension support is not available on Android
Description
This patch could be removed in favour of a chromium_src override to redefine
ManifestURL::GetWebStoreURL()
into a method that unconditionally returns an emptyGURL
Desktop Brave version:
Brave 1.23.1 (Chromium 89.0.4389.58)
Miscellaneous Information:
This removal references a patch initially introduced with brave/brave-core#215
The text was updated successfully, but these errors were encountered: