Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GCM client registration #714

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Disable GCM client registration #714

merged 1 commit into from
Oct 23, 2018

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 23, 2018 •
edited
Loading

Fixes brave/brave-browser#1716

Disabling the GCM client registration should disable the entire GCM subsystem. No other GCM-related classes will function until the client is registered.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave requested a review from bbondy October 23, 2018 13:48
@pilgrim-brave pilgrim-brave self-assigned this Oct 23, 2018
@bbondy bbondy merged commit d47dd98 into master Oct 23, 2018
bbondy added a commit that referenced this pull request Oct 23, 2018
@bbondy
Merge pull request #714 from brave/mpilgrim_disable_gcm
8af4223 
Disable GCM client registration
bbondy added a commit that referenced this pull request Oct 23, 2018
@bbondy
Merge pull request #714 from brave/mpilgrim_disable_gcm
47f8e37 
Disable GCM client registration
@bbondy
Copy link
Member

bbondy commented Oct 23, 2018

master: d47dd98
0.57.x: 8af4223
0.56.x: 47f8e37

@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
@bsclifton bsclifton mentioned this pull request May 14, 2019
Closed
@SergeyZhukovsky SergeyZhukovsky mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

Disable GCM
2 participants
@pilgrim-brave @bbondy