Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GCM #1716

Closed
pilgrim-brave opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#714 or brave/brave-core#716
Closed

Disable GCM #1716

pilgrim-brave opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#714 or brave/brave-core#716
Labels
audit-release privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Milestone
0.56.x - Release ...

Comments

@pilgrim-brave
Copy link

GCM (Google Cloud Messaging) is a deprecated but still supported way for websites to do push messaging. It routes everything through Google servers. It also provides a chrome.gcm API for extensions, which we should also disable.

Google's developer documentation: https://developers.google.com/cloud-messaging/chrome/client

Chromium code is in and around https://cs.chromium.org/chromium/src/google_apis/gcm/engine/
@bsclifton bsclifton modified the milestones: 1.x Backlog, 1.0 Oct 18, 2018
@pilgrim-brave pilgrim-brave added the privacy/connect This requires making a network connection to a third-party service. label Oct 22, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 23, 2018
@pilgrim-brave
Disable GCM cliennt registration
ba97931 
Fixes brave/brave-browser#1716
@pilgrim-brave pilgrim-brave mentioned this issue Oct 23, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.0, 0.56.x - Beta Oct 23, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 23, 2018
@pilgrim-brave
Block additional GCM entry point, add tests
8dd69fb 
Fixes brave/brave-browser#1716
@pilgrim-brave pilgrim-brave mentioned this issue Oct 23, 2018
Merged
18 tasks
@LaurenWags
Copy link
Member

@pilgrim-brave does this require manual QA? if so, can you provide a test plan please? cc @kjozwiak

@pilgrim-brave
Copy link
Author

No.

@pilgrim-brave pilgrim-brave mentioned this issue Nov 14, 2018
Closed
@simonhong simonhong mentioned this issue May 13, 2019
Open
@Laruxo Laruxo mentioned this issue Aug 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit-release privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
5 participants
@bbondy @kjozwiak @bsclifton @LaurenWags @pilgrim-brave