Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Relabel widget context menu from remove to hide #4425

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

cezaraugusto
Copy link
Contributor

Fix brave/brave-browser#7877

Submitter Checklist:

Test Plan:

  1. On NTP, click top sites widget button
  2. Should see "Hide" instead of "Remove"

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto added feature/newtab CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jan 24, 2020
@cezaraugusto cezaraugusto self-assigned this Jan 24, 2020
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩
😩 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/newtab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relabel menu item from 'remove' to 'hide'
3 participants