Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relabel menu item from 'remove' to 'hide' #7877

Closed
rebron opened this issue Jan 22, 2020 · 2 comments · Fixed by brave/brave-core#4425
Closed

relabel menu item from 'remove' to 'hide' #7877

rebron opened this issue Jan 22, 2020 · 2 comments · Fixed by brave/brave-core#4425
Assignees
@cezaraugusto
Labels
priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.5.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 22, 2020 •
edited
Loading

Description

For New Tab page widgets, rename the 'remove' label to 'Hide' to match show/hide versus add/remove terminology.

##Current screens
68592443-689c5180-0493-11ea-9b75-653fdba635aa

68592429-5fab8000-0493-11ea-9f29-e9e1a21b100c
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 22, 2020
@rebron
Copy link
Collaborator Author

rebron commented Jan 22, 2020

related to #6395

cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 24, 2020
@cezaraugusto
NTP: Relabel widget context menu from remove to hide
39c7af8 
Fix brave/brave-browser#7877
@cezaraugusto cezaraugusto mentioned this issue Jan 24, 2020
Merged
32 tasks
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 27, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Feb 26, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.5.101 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-02-26 at 3 03 33 PM

  • Verified test plan using other widgets on page (stats, clock, rewards)
  • Verified selecting to hide the widget does hide it from view
  • Verified hidden widgets can be re-displayed using the Dashboard Settings
  • Encountered Dark mode does not work for the new tab Remove menu #6395 for dark theme

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Light theme
image

Dark Theme
image

  • Verified test plan using other widgets on page (stats, clock, rewards)
  • Verified selecting to hide the widget does hide it from view
  • Verified hidden widgets can be re-displayed using the Dashboard Settings

Verification passed on

Brave 1.5.101 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Ubuntu 18.04 LTS

image

  • Verified test plan using other widgets on page (stats, clock, rewards)
  • Verified selecting to hide the widget does hide it from view
  • Verified hidden widgets can be re-displayed using the Dashboard Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

NTP: Relabel widget context menu from remove to hide brave/brave-core
6 participants
@cezaraugusto @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya