Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix ReaderMode Text Replacements #25889

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Oct 8, 2024

Resolves brave/brave-browser#41444

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Test that reader-mode still works

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 8, 2024
@Brandon-T Brandon-T self-assigned this Oct 8, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner October 8, 2024 17:24
@Brandon-T Brandon-T merged commit e39aafb into master Oct 9, 2024
18 checks passed
@Brandon-T Brandon-T deleted the bugfix/ReaderMode branch October 9, 2024 13:51
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 9, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.76

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 18 using the following build(s):

Brave | 1.73.30 Chromium: 130.0.6723.58 (Official Build) nightly (64-bit) 
--- | ---
Revision | 665076f5f0fd...
OS | iOS

Using the STR/Cases outlined via #25889 (comment), ensured that reader mode was still working without any issues as per the following:

  • ensured that tapping on the reader mode icon correctly switched over to reader mode using different websiites/articles
  • ensured that going between the regular article and reader mode worked without any issues
  • ensured that the reader mode settings worked without any issues
    • text size, font and background colour
  • ensured that reader mode was still being used when restarting Brave
Example Example Example
IMG_0598 IMG_0600 IMG_0599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone][iOS] Fix Reader Mode
5 participants