Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hackerone][iOS] Fix Reader Mode #41444

Closed
stoletheminerals opened this issue Oct 7, 2024 · 2 comments · Fixed by brave/brave-core#25889
Closed

[hackerone][iOS] Fix Reader Mode #41444

stoletheminerals opened this issue Oct 7, 2024 · 2 comments · Fixed by brave/brave-core#25889
Assignees
Labels

Comments

@stoletheminerals
Copy link

See https://hackerone.com/reports/2760854

@kjozwiak
Copy link
Member

The above requires 1.71.117 or higher for 1.71.x verification. Going to leave this as a single check rather than QA/Test-All-Platforms as we'll run through the reader mode when we're running through the manual passes for 1.71.x.

@kjozwiak kjozwiak added the bug label Oct 22, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 24, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.71.118

  • Ensured that reader mode icon is shown in the URL bar for articles.
  • Ensured reader mode works with Top Bar and Bottom Bar configurations and as well as with light/dark modes.
  • Ensured enabling reader mode works on different different articles and there are no issues toggling reader mode.
  • Ensured that reader mode settings are retained when reader mode when switching from different webpages.
  • Ensured that reader mode will continue to be used after restarting brave.
example example example example
Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants