[iOS] Timer on Sync QR Code and Phrase Words screens is not translated

[soner-yuksel]

Resolves brave/brave-browser#40051

In addition to adding missing translation for timer countdown, this Pr is also organizing the Sync localization keys and separating them to a separate file. This will help for future decoupling Sync as a library

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-13.at.14.19.34.mp4

Set device language to non-English
Launch Brave
Settings > Sync
Create a new Sync chain
Add device > Observe

[github-actions]

[puLL-Merge] - brave/brave-core@25107

Description

This PR reorganizes and updates the localization strings for the Sync feature in the Brave iOS app. It moves all Sync-related strings into a dedicated Sync namespace within the Strings struct, improving code organization and maintainability.

Changes

Changes

1. ios/brave-ios/Sources/Brave/Frontend/Settings/SettingsViewController.swift:

   • Updated string reference from Strings.sync to Strings.Sync.syncTitle

2. ios/brave-ios/Sources/Brave/Frontend/Sync/BraveCore/BraveSyncAPIExtensions.swift:

   • Updated all Sync-related string references to use the new Strings.Sync namespace

3. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncAddDevice/SyncAddDeviceDetailView.swift:

   • Updated all Sync-related string references to use the new Strings.Sync namespace

4. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncAddDevice/SyncAddDeviceViewController.swift:

   • Updated string references to use the new Strings.Sync namespace

5. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncAlerts.swift:

   • Updated all Sync-related string references to use the new Strings.Sync namespace

6. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncCameraView.swift:

   • Updated string reference to use the new Strings.Sync namespace

7. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncCodewordsView.swift:

   • Updated string reference to use the new Strings.Sync namespace

8. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncPairCameraViewController.swift:

   • Updated all Sync-related string references to use the new Strings.Sync namespace

9. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncPairWordsViewController.swift:

   • Updated all Sync-related string references to use the new Strings.Sync namespace

10. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncSelectDeviceTypeViewController.swift:

    • Updated all Sync-related string references to use the new Strings.Sync namespace

11. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncSettingsTableViewController.swift:

    • Updated all Sync-related string references to use the new Strings.Sync namespace

12. ios/brave-ios/Sources/Brave/Frontend/Sync/SyncWelcomeViewController.swift:

    • Updated all Sync-related string references to use the new Strings.Sync namespace

13. ios/brave-ios/Sources/Brave/Frontend/Widgets/LoadingViewController.swift:

    • Updated Sync-related string references to use the new Strings.Sync namespace

14. ios/brave-ios/Sources/BraveStrings/BraveStrings+Sync.swift:

    • Added a new file containing all Sync-related localization strings within the Strings.Sync namespace

15. ios/brave-ios/Sources/BraveStrings/BraveStrings.swift:

    • Removed all Sync-related strings that have been moved to the new BraveStrings+Sync.swift file

This refactoring improves code organization by grouping all Sync-related strings together and makes it easier to maintain and update these strings in the future.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push