Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Timer on Sync QR Code and Phrase Words screens is not translated #40051

Closed
1 of 5 tasks
hffvld opened this issue Jul 26, 2024 · 2 comments · Fixed by brave/brave-core#25107
Closed
1 of 5 tasks

Comments

@hffvld
Copy link
Contributor

hffvld commented Jul 26, 2024

Description

Follow-up to #39617.

Steps to reproduce

  1. Set device language to non-English
  2. Launch Brave
  3. Settings > Sync
  4. Create a new Sync chain
  5. Add device > Observe

Actual result

The timer on the Sync QR Code and Phrase Words screens are not translated.


Russian Spanish German Japanese
1 2 3 4
1 2 3 4

Expected result

The timer string on the Sync QR Code and Phrase Words screens must be translated.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.68 (130)
BraveCore: 1.68.130 (127.0.6533.73)

Device/iOS version

iPhone 14 / iOS 17.6

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@hffvld hffvld added bug l10n feature/sync QA/Yes OS/iOS Fixes related to iOS browser functionality labels Jul 26, 2024
@soner-yuksel soner-yuksel changed the title [Follow up to #39617][l10n] Timer on Sync QR Code and Phrase Words screens is not translated [l10n] Timer on Sync QR Code and Phrase Words screens is not translated Aug 13, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 14, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 18, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Oct 18, 2024

All screens for the Sync chain are regressed and not translated into non-English languages. It's impossible to verify this issue right now.

Filed follow-up issue #41731


Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.71 (115)
BraveCore: 1.71.115 (130.0.6723.58)

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

cc @Brandon-T

@hffvld hffvld removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 18, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 7, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Nov 7, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.72 (96)
BraveCore: 1.72.96 (131.0.6778.24)

STEPS:

  1. Follow the STR/TP from [l10n] Timer on Sync QR Code and Phrase Words screens is not translated #40051 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the timer on Sync QR Code and Phrase Words screens is translated into other languages

Russian

1 2
1 2

Japanese

1 2
1 2

Arabic

1 2
1 2

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants