Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Add contract address link out to transaction confirmation panel #24686

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

StephenHeaps
Copy link
Collaborator

Resolves brave/brave-browser#39720

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Visit https://bbondy.github.io/eth-manual-tests/request.html
  2. Tap eth_requestAccounts and connect an ethereum account
  3. In the wallet panel, change the network to Sepolia Test Network
  4. Enter a to address next to eth_signTransaction then tap eth_signTransaction
  5. Verify the to address is still displayed as before (truncated address if it's not one from your wallet, otherwise will show account name)
  6. Enter 0xdb6f1920a889355780af7570773609bd8cb1f498 next to eth_signTransaction then tap eth_signTransaction
  7. Verify that the to address displays as Contract Address with a link out button, and tapping on the contract address will link out to the block explorer showing the code for the contract address.
Contract Address Non Contract Address

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jul 16, 2024
@StephenHeaps StephenHeaps self-assigned this Jul 16, 2024
@StephenHeaps StephenHeaps requested a review from nuo-xu July 17, 2024 13:56
@StephenHeaps StephenHeaps marked this pull request as ready for review July 17, 2024 13:56
@StephenHeaps StephenHeaps requested a review from a team as a code owner July 17, 2024 13:56
@StephenHeaps StephenHeaps merged commit 091e0da into master Jul 19, 2024
17 checks passed
@StephenHeaps StephenHeaps deleted the wallet/ios-tx-confirmation-contract-address branch July 19, 2024 15:10
@github-actions github-actions bot added this to the 1.70.x - Nightly milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS transaction confirmation panel contract address link out
2 participants