Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS transaction confirmation panel contract address link out #39720

Closed
StephenHeaps opened this issue Jul 12, 2024 · 1 comment · Fixed by brave/brave-core#24686
Closed

iOS transaction confirmation panel contract address link out #39720

StephenHeaps opened this issue Jul 12, 2024 · 1 comment · Fixed by brave/brave-core#24686
Assignees
@StephenHeaps
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.70.x - Release

Comments

@StephenHeaps
Copy link

Platforms

iOS

Description

When sending to a contract address, should treat the contract address as a link to the block explorer in the transaction confirmation panel and link out to the iOS browser when tapped on, similar to desktop behaviour:

Transaction Confirmation Contract Address Link Out
@StephenHeaps StephenHeaps added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 12, 2024
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Jul 12, 2024
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jul 15, 2024
@StephenHeaps StephenHeaps mentioned this issue Jul 16, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jul 19, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 19, 2024
@StephenHeaps StephenHeaps added OS/iOS Fixes related to iOS browser functionality release-notes/include labels Jul 22, 2024
@kjozwiak kjozwiak mentioned this issue Sep 25, 2024
Closed
19 tasks
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 18 running 1.70 (119)

  • Verified steps from brave/brave-core#24686
  • Verified Address continues to show as truncated address
  • Verified Contract address shows as truncated address with a hyper link to load in new tab
  • Verified named address continues to show the name
image image image

@Uni-verse Uni-verse mentioned this issue Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add contract address link out to transaction confirmation panel brave/brave-core
3 participants
@StephenHeaps @srirambv @brave-builds