Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): New Quote Countdown #24050

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Jun 6, 2024

Description

Introduces a countdown ticker showing the time in until a new quote is fetched on the Swap and Bridge screens.

Resolves brave/brave-browser#34583

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Swap or Bridge screen
  2. Generate a quote for a swap.
  3. You should see a countdown ticker displayed, showing the time until a new quote is fetched.
Screen.Recording.2.mov

@Douglashdaniel Douglashdaniel self-assigned this Jun 6, 2024
@Douglashdaniel Douglashdaniel requested review from a team as code owners June 6, 2024 18:42
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jun 6, 2024
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@muliswilliam muliswilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend ++

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-new-quote-countdown branch from d54807a to 47906f3 Compare June 7, 2024 15:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-new-quote-countdown branch from 47906f3 to f7de84c Compare June 10, 2024 13:27
@Douglashdaniel Douglashdaniel requested a review from mkarolin June 10, 2024 13:28
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 18599b0 into master Jun 10, 2024
19 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-new-quote-countdown branch June 10, 2024 15:29
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build out New Quote Countdown
5 participants