Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out New Quote Countdown #34583

Closed
Douglashdaniel opened this issue Nov 28, 2023 · 1 comment · Fixed by brave/brave-core#24050
Closed

Build out New Quote Countdown #34583

Douglashdaniel opened this issue Nov 28, 2023 · 1 comment · Fixed by brave/brave-core#24050
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Nov 28, 2023 •
edited
Loading

Description

For Bridge and Swap we need to display a countdown ticker showing the time in seconds until a new quote is fetched.

Screenshot 24
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 28, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 28, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 28, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Dec 6, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to Backlog in Web3 Jan 23, 2024
@Douglashdaniel Douglashdaniel mentioned this issue May 24, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Jun 6, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jun 6, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 6, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 10, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 10, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.124 Chromium: 127.0.6533.73 (Official Build) beta (64-bit)
Revision dbc9035349f74e493f3293d93f4cbf35c597dfec
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24050
  • Verified countdown starts for 10sec when quote is fetched for Swap/Bridge
  • Verified Review Swap or Review Bridge button changes to Fetching quote when the countdown ends or manually refreshed
34583.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): New Quote Countdown brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds