Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add support for the marketplace URI scheme #22403

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[iOS] Add support for the marketplace URI scheme #22403

merged 1 commit into from
Apr 18, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 29, 2024 •
edited
Loading

This change is required to handle third-party marketplace app installs on iOS 17.4 in the EU

Resolves brave/brave-browser#37650

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Currently there are no public third-party App Stores in the EU right now, so marking as a QA/No for now, we can test in the future as they become available

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 29, 2024
@kylehickinson kylehickinson force-pushed the ios-marketplace-scheme-handler branch from 5ca4cd2 to 4586241 Compare February 29, 2024 20:29
@kylehickinson kylehickinson force-pushed the ios-marketplace-scheme-handler branch from 4586241 to 3d16d9f Compare April 17, 2024 13:52
@kylehickinson kylehickinson marked this pull request as ready for review April 17, 2024 13:54
@kylehickinson kylehickinson requested a review from a team as a code owner April 17, 2024 13:54
@kylehickinson
[iOS] Add support for the marketplace URI scheme
c761f43 
This change is required to handle third-party marketplace app installs on iOS 17.4 in the EU
@kylehickinson kylehickinson force-pushed the ios-marketplace-scheme-handler branch from 3d16d9f to c761f43 Compare April 17, 2024 13:55
@Brandon-T Brandon-T merged commit 7412bee into master Apr 18, 2024
19 checks passed
@Brandon-T Brandon-T deleted the ios-marketplace-scheme-handler branch April 18, 2024 11:43
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 18, 2024
kylehickinson added a commit that referenced this pull request Apr 19, 2024
@kylehickinson
[iOS] Add support for the marketplace URI scheme (#22403)
b7c2b67 
- Handle third-party marketplace app installs on iOS 17.4 in the EU
kylehickinson added a commit that referenced this pull request Apr 19, 2024
@kylehickinson
[iOS] Add support for the marketplace URI scheme (#22403)
aaeb1a0 
- Handle third-party marketplace app installs on iOS 17.4 in the EU
This was referenced Apr 19, 2024
Merged
Merged
kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
@kylehickinson
[iOS] Add support for the marketplace URI scheme (Uplift to 1.66.x) (#…
592ca7d 
…23182)

[iOS] Add support for the marketplace URI scheme (#22403)

- Handle third-party marketplace app installs on iOS 17.4 in the EU
kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
@kylehickinson
[iOS] Add support for the marketplace URI scheme (Uplift to 1.65.x) (#…
900fe02 
…23181)

[iOS] Add support for the marketplace URI scheme (#22403)

- Handle third-party marketplace app installs on iOS 17.4 in the EU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brandon-T Brandon-T Brandon-T approved these changes

@stoletheminerals stoletheminerals stoletheminerals approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.

Add support for opening third-party App Stores/Marketplace URLs
3 participants
@kylehickinson @Brandon-T @stoletheminerals