Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scrollbar for unverified notice on MacOS #2125

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Fixes scrollbar for unverified notice on MacOS #2125

merged 1 commit into from
Mar 31, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 31, 2019

Fixes: brave/brave-browser#3930
UI: brave/brave-ui#439

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Defined in issue, but for testing on MacOS please go in to general preferences and make sure that scrollbar is always set to show.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml merged commit 88d89d2 into master Mar 31, 2019
@ryanml ryanml deleted the fix-3930 branch March 31, 2019 06:41
ryanml added a commit to ryanml/brave-core that referenced this pull request Apr 1, 2019
Fixes scrollbar for unverified notice on MacOS
ryanml added a commit that referenced this pull request Apr 2, 2019
Fixes scrollbar for unverified notice on MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar in message for unverified publisher in Rewards Panel
2 participants