Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar in message for unverified publisher in Rewards Panel #3930

Closed
btlechowski opened this issue Mar 28, 2019 · 7 comments · Fixed by brave/brave-core#2125
Closed

Scrollbar in message for unverified publisher in Rewards Panel #3930

btlechowski opened this issue Mar 28, 2019 · 7 comments · Fixed by brave/brave-core#2125

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Enable rewards
  2. Go to interia.pl
  3. Open Brave Panel

Actual result:

image

Expected result:

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.24 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Reproducible on current release:

Not reproducible on

Brave 0.61.52 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523

Not reproducible on

Brave 0.62.45 Chromium: 73.0.3683.86(Official Build) beta (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523

Not reproducible on

Brave 0.63.20 Chromium: 73.0.3683.75(Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @NejcZdovc

@NejcZdovc
Copy link
Contributor

@btlechowski is scroll bar only there or you can actually scroll?

@btlechowski
Copy link
Author

@NejcZdovc The scroll bar is just there. It is inactive. Cannot scroll.

@NejcZdovc
Copy link
Contributor

@ryanml can you please take a look why that is the case

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 28, 2019
@ryanml
Copy link
Contributor

ryanml commented Mar 28, 2019

@NejcZdovc Can fix, I'm guessing that the content just exceeds the max height so we get a useless scrollbar.

@bsclifton
Copy link
Member

bsclifton commented Mar 28, 2019

@ryanml I ran into a similar issue in a PR that @petemill had - if you're having trouble reproducing, it may be tied to using a physical mouse (instead of a track pad / magic mouse)

@petemill
Copy link
Member

petemill commented Mar 28, 2019

This is reproducible in macos on any site if you change your macOS scroll Preferences (under General) to 'Show scroll bars: Always`

Fixed with overflow-y: auto instead of overflow-y: scroll

image

@btlechowski
Copy link
Author

btlechowski commented Apr 24, 2019

Verification passed on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

image

In Polish language:
image

Verified passed with

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta(64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X

Verification passed on

Brave 0.64.62 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment